Want r336873 for https://bugs.llvm.org/show_bug.cgi?id=38126

Want r336941 for issue 856239.

r337038 for  issue 841916 .

Looks like r336882 is a follow-up to r336873

And also r336941 is a follow-up for issue 856239.

(that's already listed in comment 1 :-) )

Oops, sorry for the spam, I got totally confused with another issue (https://github.com/google/oss-fuzz/issues/910) that requires r337068 as a followup.

I'm trying to update clang.
https://chromium-review.googlesource.com/c/chromium/src/+/1143094

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5ccad18ad8eda700d4215252f8f9709df76b85a

commit d5ccad18ad8eda700d4215252f8f9709df76b85a
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Jul 19 17:04:04 2018

Roll clang 336424:337439.

Ran `tools/clang/scripts/upload_revision.py 337439`.

Bug:  863425 
Change-Id: Ib7aded4ae26639e0d14078bb78b88ad5a29b028d
Reviewed-on: https://chromium-review.googlesource.com/1143094
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576531}
[modify] https://crrev.com/d5ccad18ad8eda700d4215252f8f9709df76b85a/tools/clang/scripts/update.py

The compiler seems to be crashing when I'm building browser_tests for ChromeOS with code coverage instrumentation. However, I'm not sure if it wasn't crashing before the roll, as I haven't built this target before. I'll check the build on the older revision.

Alright, the roll is not an issue. Previous revision is also crashing while building browser_tests in that config.

Triage: Marking assigned.

Next roll is  issue 866225 .

Looks like this one stuck. Thanks tikuta for the help!

Strangely, this roll ( https://chromium-review.googlesource.com/c/chromium/src/+/1143094 ) has affected my local build of Skia on Linux with ASAN only. In a local Skia checkout like

$ git clone https://skia.googlesource.com/skia
$ cd skia
$ tools/git-sync-deps
$ bin/fetch-gn

with an out/asan/args.gn which looks like

cc = "$HOME/src/chromium/src/third_party/llvm-build/Release+Asserts/bin/clang"
cxx = "$HOME/src/chromium/src/third_party/llvm-build/Release+Asserts/bin/clang++"
sanitize = "ASAN"
is_debug = true

$ bin/gn gen out/asan

$ ninja -C out/asan/ fuzz
/usr/bin/ld: fuzz: hidden symbol `_ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE11__recommendEm' isn't defined

$ c++filt _ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE11__recommendEm
std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__recommend(unsigned long)

sure enough I can find this __recommend in libc++, but it doesn't seem to have changed in a while. My debug build of Skia (without 'sanitize = "ASAN"') links fine. If I locally revert this change in Chromium, run the hooks to get the 'old' clang, and then rebuild everything is fine.

Can you file a new bug for that, please?

Sure, opened  issue 866657 .