New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863420 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Chrome crashes after the "<Someone else> was previously using Chrome" dialog

Project Member Reported by tangltom@chromium.org, Jul 13

Issue description

Chrome Version: 69.0.3491.0 (Developer Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) sign into chrome
(2) sign out
(3) try to sign in with a different account
(4) "<Someone else> was previously using Chrome" dialog pops up
(5) click "Continue"

What is the expected result?
Chrome creates a new profile with the new account syncing.

What happens instead?
Chrome crashes.

Here is the stack trace:

[89187:89187:0713/163804.558256:FATAL:signin_email_confirmation_dialog.cc(190)] Check failed: false. Unexpected action value [unknown]
#0 0x55bbc70567cc base::debug::StackTrace::StackTrace()
#1 0x55bbc6fa450b logging::LogMessage::~LogMessage()
#2 0x55bbc996665b SigninEmailConfirmationDialog::OnDialogClosed()
#3 0x55bbc97f3b9f ConstrainedWebDialogUI::OnDialogCloseMessage()
#4 0x55bbc5668e05 content::WebUIImpl::ProcessWebUIMessage()
#5 0x55bbc5668014 content::WebUIImpl::OnWebUISend()
#6 0x55bbc5667dbc _ZN3IPC8MessageTI27FrameHostMsg_WebUISend_MetaNSt3__15tupleIJNS2_12basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEN4base9ListValueEEEEvE8DispatchIN7content9WebUIImplESG_NSF_15RenderFrameHostEMSG_FvPSH_RKS9_RKSB_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#7 0x55bbc5667ce9 content::WebUIImpl::OnMessageReceived()
#8 0x55bbc561f731 content::WebContentsImpl::OnMessageReceived()
#9 0x55bbc52ab475 content::RenderFrameHostImpl::OnMessageReceived()
#10 0x55bbc54cc58b content::RenderProcessHostImpl::OnMessageReceived()
#11 0x55bbc768f291 IPC::ChannelProxy::Context::OnDispatchMessage()
#12 0x55bbc4988cb8 _ZN4base8internal7InvokerINS0_9BindStateIMN5media20AudioInputControllerEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEEEJ13scoped_refptrIS4_ESB_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#13 0x55bbc6fad4ad base::debug::TaskAnnotator::RunTask()
#14 0x55bbc6fabb26 base::MessageLoop::RunTask()
#15 0x55bbc6fabf3a base::MessageLoop::DeferOrRunPendingTask()
#16 0x55bbc6fac26c base::MessageLoop::DoWork()
#17 0x55bbc6fb19bf base::(anonymous namespace)::WorkSourceDispatch()
#18 0x7f116b9caf07 g_main_context_dispatch
#19 0x7f116b9cb138 <unknown>
#20 0x7f116b9cb1cc g_main_context_iteration
#21 0x55bbc6fb1772 base::MessagePumpGlib::Run()
#22 0x55bbc6fab491 base::MessageLoop::Run()
#23 0x55bbc6fd7ab6 base::RunLoop::Run()
#24 0x55bbc6bf8718 ChromeBrowserMainParts::MainMessageLoopRun()
#25 0x55bbc511a447 content::BrowserMainLoop::RunMainMessageLoopParts()
#26 0x55bbc511d5c3 content::BrowserMainRunnerImpl::Run()
#27 0x55bbc51161d9 content::BrowserMain()
#28 0x55bbc6b9bc34 content::ContentMainRunnerImpl::Run()
#29 0x55bbc6bd2309 service_manager::Main()
#30 0x55bbc6b99c91 content::ContentMain()
#31 0x55bbc42e41b3 ChromeMain
#32 0x7f116794e2b1 __libc_start_main
#33 0x55bbc42e402a _start

David said you were working on this Mihai, so assigning to you.

 
Cc: droger@chromium.org
Labels: ReleaseBlock-Beta M-69
We need to fix this before beta is launched to avoid adding crashes.
Labels: Hotlist-Unity-MVP
Status: Started (was: Assigned)
Mergedinto: 865814
Status: Duplicate (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d639a2216dbcb495fa30951ce98d7fbb5e7b36

commit a0d639a2216dbcb495fa30951ce98d7fbb5e7b36
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Tue Jul 24 12:41:14 2018

Fix consent feature enum.

Bug:  863420 
Change-Id: I01e883bda9207614a99b9e2d6c02813d3d56984c
Reviewed-on: https://chromium-review.googlesource.com/1146814
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577495}
[modify] https://crrev.com/a0d639a2216dbcb495fa30951ce98d7fbb5e7b36/components/consent_auditor/consent_auditor.h

Labels: Merge-Rejected-69
Status: Fixed (was: Duplicate)
This was actually not a duplicate as marked previously. We should merge this back to M69.
Labels: -Merge-Rejected-69 Merge-Request-69
Fixing typo
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 27

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe4af6b340c49fa5f82d480d89cc062656383d2

commit cbe4af6b340c49fa5f82d480d89cc062656383d2
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Fri Jul 27 12:25:24 2018

Fix consent feature enum.

Bug:  863420 
Change-Id: I01e883bda9207614a99b9e2d6c02813d3d56984c
Reviewed-on: https://chromium-review.googlesource.com/1146814
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577495}(cherry picked from commit a0d639a2216dbcb495fa30951ce98d7fbb5e7b36)
Reviewed-on: https://chromium-review.googlesource.com/1152947
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#146}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/cbe4af6b340c49fa5f82d480d89cc062656383d2/components/consent_auditor/consent_auditor.h

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on ubuntu 17.10 using chrome reported version #69.0.3491.0 as per comment #0. Observed that the chrome did not crash after clicking "continue" when "<Someone else> was previously using Chrome" dialog popped up.
Attached a screen cast for reference.

msarda@ - Could you please check the attached screen cast and please let us know if anything missed from our end in reproducing the issue.

Thanks...!!
863420.webm
6.6 MB View Download
Labels: -Needs-Feedback
This was a DCHECK so it would not reproduce on an official build (only in a developer one). I merged it back to M69 as it was really annoying to test anything that had to do with signing in to Chrome in M69.

krajshree@chromium.org: There is nothing missing from your end on this bug.

Sign in to add a comment