New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863405 link

Starred by 0 users
Status: WontFix
Owner:
maxwalker@chromium.org
Closed: Jul 13
Cc:
maxwalker@chromium.org
vasi...@chromium.org
█ nepper@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Password bubble and its button out of sync

Project Member Reported by vabr@chromium.org, Jul 13 
Chrome Version       : 69.0.3491.0 (Developer Build) (64-bit)
OS Version: all desktop + CrOS

What steps will reproduce the problem?
1. Go to https://rsolomakhin.github.io/autofill/, save a password.
2. Go to https://rsolomakhin.github.io/autofill/ again, modify the filled password, click the key icon in the omnibox.
3. Edit the username in the bubble so that there is no saved credential with that username yet.


What is the expected result?
The title of the bubble and the positive button should remain consistent. They should both say "update" or both "save".

What happens instead of that?
After step 3, the positive button changes from Update to Save, reflecting the fact that there is no saved credential with the new username. However, the bubble's title does not change.

This also happens in the other direction (change the username in the form, click the key icon, change the username in the bubble back to the already saved one; then the title is "Save" and the button "Update").

Screenshots attached.

I am Cc-ing Vasilii as the eng expert on this UI, Patrick as the "PM of the PM" and Max as the UI expert.
title-save-button-update.png
16.2 KB View Download
title-update-button-save.png
15.1 KB View Download

Comment 1 by vasi...@chromium.org, Jul 13

Owner: maxwalker@chromium.org
This is what we agreed on in Q1. Indeed the title is fixed for the lifetime of the dialog (imagine the whole content would jump up and down). The "Nope"/"never" button is also static. It answers the question in the title.
The Save button changes the title dynamically to depict the current action possible.
If Max has no concerns, I'll close the bug.

Comment 2 by vabr@chromium.org, Jul 13

Status: WontFix (was: Available)
Thanks, Vasilii, for the remainder that this has been already discussed. Good to have one more record of that here.

Given the previous agreement from Q1, let me close this straight away, Max (or Patrick) can re-open if there are concerns.
►

Sign in to add a comment