New issue
Advanced search Search tips

Issue 863402 link

Starred by 2 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Jul 16
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Adjust find in page in and out animations

Project Member Reported by gambard@chromium.org, Jul 13 
IPad only

What steps will reproduce the problem?
(1) Open Find In Page
(2) Close it

What is the expected result?
The appearance and disappearance animation should be smooth.

What happens instead?
It is not smooth.

Comment 1 by gambard@chromium.org, Jul 13

Labels: S-FindBar
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aba25af14971812ce432abea43b5f3138754c7da

commit aba25af14971812ce432abea43b5f3138754c7da
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Jul 16 14:43:24 2018

[iOS] Update FindInPage animations

This CL changes the FindInPage appearance/disappearance animations,
making them smoother.

Bug:  863402 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3712133c83f8bda2baef9e103c10c008326a567c
Reviewed-on: https://chromium-review.googlesource.com/1136542
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575254}
[modify] https://crrev.com/aba25af14971812ce432abea43b5f3138754c7da/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm

Comment 3 by gambard@chromium.org, Jul 16

Status: Fixed (was: Assigned)

Comment 4 by shbarezer@chromium.org, Jul 24

Status: Verified (was: Fixed)
Verified in 70.0.3501.0 Canary,  iPad Pro iOS11.4
Looks good.
►

Sign in to add a comment