Google Doodle animation goes out of screen on dismissing the GLIF screen in landscape mode. |
||||||||||||
Issue descriptionApp Version: 69.0.3490.0 Canary iOS Version: 10.3.3,iOS 11 Device: iPads Only Steps to reproduce: 1. Launch Chrome in Landscape mode 2. Scroll the screen slightly upwards. 3. Tap On Google Mic icon. 4. Tap on Close(X) to dismiss the GLIF screen. Observed results: Google Doodle animation goes out of screen Expected results: Google Doodle animation should be smooth. Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : Yes in M8 Bug reproducible on the current beta channel build : Yes in M69 Link to video/image: https://drive.google.com/file/d/11cOzmASzUk_qYLvydofB79lIEhEVQSrj/view?usp=sharing
,
Jul 13
kkhorimoto@ what should happen here?
,
Jul 16
I agree this is not a P1 for M69.
,
Jul 17
,
Aug 8
P1 for M70 as a rotation issue.
,
Aug 31
,
Aug 31
,
Sep 1
,
Sep 1
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a26c112700183654bfb19e221b9b269d60bd9d49 commit a26c112700183654bfb19e221b9b269d60bd9d49 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Sep 06 19:44:36 2018 [iOS] Don't reparent logo for voice search view unless fully visible. This CL updates the NTP to only return the logo animation controller for voice search transition animations if the logo is fully visible. Bug: 863381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I73b68748d89cea6bd9b0292847496760c41e66b6 Reviewed-on: https://chromium-review.googlesource.com/1200570 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589246} [modify] https://crrev.com/a26c112700183654bfb19e221b9b269d60bd9d49/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
,
Sep 6
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b1b9820da4e4213cc41bc84250dcd3b66b8e3ae commit 0b1b9820da4e4213cc41bc84250dcd3b66b8e3ae Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Mon Sep 10 18:23:02 2018 [iOS] Don't reparent logo for voice search view unless fully visible. This CL updates the NTP to only return the logo animation controller for voice search transition animations if the logo is fully visible. Bug: 863381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I73b68748d89cea6bd9b0292847496760c41e66b6 Reviewed-on: https://chromium-review.googlesource.com/1200570 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589246}(cherry picked from commit a26c112700183654bfb19e221b9b269d60bd9d49) Reviewed-on: https://chromium-review.googlesource.com/1216720 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#234} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/0b1b9820da4e4213cc41bc84250dcd3b66b8e3ae/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
,
Sep 11
Verified on chrome canary version 71.0.3549.0 on iPad Air with iOS 11.3.3, 12 beta 12. No overlapping on google doodle animation is seen. Looks good.
,
Sep 14
Verified in: App Version: 70.0.3538.17 beta Devices: iPadMini iOS Version: 11.4.1, 12.0 beta 12 Google Doodle is not displayed on voice search transition animation. Video: https://drive.google.com/open?id=1RmO7h-UHIXuyIryn6dGcxY1y0O8vcKMQ |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by stkhapugin@chromium.org
, Jul 13Components: -UI>Browser>Omnibox
Labels: -Pri-2 Pri-3
Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)