New issue
Advanced search Search tips

Issue 863360 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Jul 20
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Select a destination' overlay doesn't get closed on pressing 'Esc' key.

Reported by dchau...@etouch.net, Jul 13 
Chrome Version: 69.0.3489.0 (Official Build) Revision	66d7b6411564744a0d3589943331a0a7db096a3d-refs/branch-heads/3489@{#1} 32/64-bit.
OS: Windows(7,8,8.1,10) and Linux(14.04).

Pre-condition: Enable 'Enable new Print Preview UI' flag from chrome://flags

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage using "Ctrl + P" key from keyboard.
2. Click on 'Change' button under 'Destination' section to open 'Select a destination' overlay.
3. Now press 'Esc' key from keyboard and observe.

Actual: Nothing happens on pressing 'Esc' key from keyboard.
Expected: 'Select a destination' overlay should get closed on pressing 'Esc' key.

This is a regression issue, broken in M-69 series, below is manual regression range.

Good build: 69.0.3488.0 (Revision: 574035)
Bad build: 69.0.3489.0 (Revision: 574445)

Unable to provide the bisect using has-bisect-per-revision script. Hence providing the bisect using Chromium bisect:

You are probably looking for a change made after 574073 (known good), but no later than 574079 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c61a083bfa16fb5c693c86c219981b9c114bda09..ff940402c857175193f8eb20812ee789bc784268

Suspecting: https://chromium.googlesource.com/chromium/src/+/ff940402c857175193f8eb20812ee789bc784268

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is not reproducible on Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) OS.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
888 KB View Download
Expected behavior.mp4
1006 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4227f14b082a559f5d894c8ef22c227395f0477a

commit 4227f14b082a559f5d894c8ef22c227395f0477a
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jul 20 00:56:22 2018

Print Preview Componentization: Make escape key close dialogs

Focusing the search box prevented the escape key from closing the
destination/advanced settings dialogs. Fix this regression.

Bug:  863360 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib408969df14cab47c9ec38ad60169b2577498049
Reviewed-on: https://chromium-review.googlesource.com/1137711
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576730}
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/advanced_options_settings.js
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/4227f14b082a559f5d894c8ef22c227395f0477a/chrome/browser/resources/print_preview/new/destination_settings.js

Comment 2 by dchau...@etouch.net, Jul 20

Labels: TE-Verified-69.0.3497.0 TE-Verified-M69
Update:
Rechecked the above issue on Windows(7,8,8.1,10) and Linux(14.04) machines using latest canary #69.0.3497.0 and issue is fixed. Hence adding TE-Verified labels.

please refer below attached screen-cast for reference.

Thank You.
Fixed_Screenshot.mp4
858 KB View Download

Comment 3 by rbpotter@chromium.org, Jul 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment