New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863356 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ atul.mog...@synerzip.com
█ nagmani....@synerzip.com
█ snopanen@google.com
sdoerner@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

In Canary 69 version, pop-ups blocked warning appears when user click the links from ‘Office editing for Docs, Sheets & Slides’ extension

Project Member Reported by amit.jo...@synerzip.com, Jul 13 
Chrome Version:  Google Chrome	69.0.3489.0 (Official Build) canary (64-bit) (cohort: Clang-64)
OS: (e.g. Win7/10, MacOS 10.13.3)
Chrome QuickOffice Build: Local Engineering build-(Migrate from streamsPrivate to mimeHandlerPrivate)
https://build.chromium.org/p/client.chromeoffice.try/builders/bundle_app/builds/7145


Scenario-1

What steps will reproduce the problem?
(1) Open a file in Chrome QuickOffice
(2) Click on the module icon, which has a link to 'Google Docs Home page'
(3) Observe the behavior

What is the expected result?
Links should open in a new tab without any pop-ups blocked warning

What happens instead?
Pop-ups blocked warning appears when user click any link/ hyperlinks from Chrome QuickOffice. However, after allowing the pop-ups, links are opening properly in a new tab.

Similar behavior noticed for following use cases as well.

Scenario-2
(1) Open a file in Chrome QuickOffice
(2) Click 'Office Compatibility Mode' option from any top level menus (Example: File > Office Compatibility Mode)
(3) Click 'Learn More' link on OCM promo dialog
(4) Observe the behavior
< Applicable for all such links present on allthe modal dialog within Chrome QuickOffice extension >

Scenario-3
(1) Open attached file (Hyperlink_Properties.docx) in Chrome QuickOffice
(2) Click on a hyperlink within the document (Example: www.google.com)
(3) Observe the behavior

Please refer attached screens.
Pop-ups blocked 1.png
72.4 KB View Download
Pop-ups blocked 2.png
107 KB View Download
Pop-ups blocked 3.png
166 KB View Download
Hyperlink_Properties.docx
67.6 KB Download

Comment 1 by amit.jo...@synerzip.com, Jul 13

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b3e2d9493ce36a2f1e627b4e51bc44e22aee499

commit 7b3e2d9493ce36a2f1e627b4e51bc44e22aee499
Author: Sam McNally <sammc@chromium.org>
Date: Thu Jul 19 23:48:51 2018

Inherit the user-gesture state of the mime handler for opening new tabs.

The popup blocker denies OpenURLFromTab() calls without a user gesture.
The calls made from MimeHandlerViewGuest in response to
ShouldCreateWebContents() calls (resulting from clicks on anchors with
target="_blank") defaulted to not having a user gesture, causing them to
always be blocked.

Assume user gesture for mime handlers to avoid
this problem. Mime handlers can only be a whitelisted set of extensions,
so this difference in enforcement is unlikely to result in many
undesired popups.

Bug:  819761 ,863356
Tbr: ekaramad@chromium.org
Change-Id: Ia0c36a6e7c7b3dfd74cd9e0661cc69866bb962d5
Reviewed-on: https://chromium-review.googlesource.com/1135878
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@google.com>
Cr-Commit-Position: refs/heads/master@{#576699}
[modify] https://crrev.com/7b3e2d9493ce36a2f1e627b4e51bc44e22aee499/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
[modify] https://crrev.com/7b3e2d9493ce36a2f1e627b4e51bc44e22aee499/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Comment 3 by amit.jo...@synerzip.com, Jul 20 

All the above scenarios works fine with latest Chrome Canary version-
69.0.3497.0 (Official Build) canary (64-bit)

Chrome QuickOffice Build: Local Engineering build-(Migrate from streamsPrivate to mimeHandlerPrivate)
https://build.chromium.org/p/client.chromeoffice.try/builders/bundle_app/builds/7145
►

Sign in to add a comment