New issue
Advanced search Search tips

Issue 863355 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: ----



Sign in to add a comment

external/wpt/svg/shapes/reftests/pathlength-002.svg has subpixel differences on Mac

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jul 13

Issue description

WPT import https://crrev.com/c/1136223 introduced new failures in external/wpt/svg:

List of new failures:
[ Mac ] external/wpt/svg/shapes/reftests/pathlength-002.svg [ Failure ]
external/wpt/svg/shapes/reftests/pathlength-003.svg [ Failure ]
external/wpt/svg/text/reftests/textpath-side-001.svg [ Failure ]
external/wpt/svg/text/reftests/textpath-shape-001.svg [ Failure ]

This import contains upstream changes from ceba83a56edd838cca0aacd35549f979292a5995 to e9385e019228141b8df04360ad80d39af2fa781f:
Test fetch abort with keepalive (#11822): https://github.com/web-platform-tests/wpt/commit/e9385e019228141b8df04360ad80d39af2fa781f
Revert "Correctly initialize and test SnapContainerData in cc.": https://github.com/web-platform-tests/wpt/commit/211d3165a3b66b6a8eb85a765b0aedb60410ab88
Update the remote-playback IDL + test (#11944): https://github.com/web-platform-tests/wpt/commit/2ef7f40f10060dbc7bd677f649d3111e3b0c4314
Correctly initialize and test SnapContainerData in cc.: https://github.com/web-platform-tests/wpt/commit/ffcd0bede8fa1e7da8c8216655193584795dcca7
Add support for external scripts in wpt .any.js tests in jstests harness: https://github.com/web-platform-tests/wpt/commit/f51bd629cff1ccc71d6c013c985708a70dd015f1
Merge pull request #11295 from Tavmjong/textpath: https://github.com/web-platform-tests/wpt/commit/b91ac7ed416c366f50f9afceb531f3fd5e41bc7e
Merge pull request #11712 from Tavmjong/shape_pathlength: https://github.com/web-platform-tests/wpt/commit/e5c8fac2b2f5ea49359b40173a81ee56014abea4
Add WindowPostMessageOptions and a new postMessage overload.: https://github.com/web-platform-tests/wpt/commit/1bbb7050e6f33d2b3a64a763fd6405542a74dd45
Add a fail-fast for longtask layouttests: https://github.com/web-platform-tests/wpt/commit/cd75119c6b1fe0fd7721e1abece1acab38397d7e
Clone service worker objects to nested workers: https://github.com/web-platform-tests/wpt/commit/6f42857497ddf6683bc86a7cdce6049aebcb3173
Change 'help' link from shape.html#RectElement to shape.html#CircleElement.: https://github.com/web-platform-tests/wpt/commit/5d963ed48a89f411e032087a08da7038dd0cd5e0 [affecting this directory]
Add basic 'pathLength' tests on shapes.: https://github.com/web-platform-tests/wpt/commit/87a770b21b9e7e1e940e30ee567bef0c3cc5b4f5 [affecting this directory]
Add 'textPath' tests: 'side' attribute, text on basic shapes.: https://github.com/web-platform-tests/wpt/commit/ca4a5fddbe9ee81067cda0b21ea42c5429726f51 [affecting this directory]

 
external/wpt/svg/shapes/reftests/pathlength-002.svg

Passes but likely has (subpixel) differences - hence the Mac-only failure. Not sure there anything we can do there before there's a possibility to add an "error bound".

external/wpt/svg/shapes/reftests/pathlength-003.svg
external/wpt/svg/text/reftests/textpath-shape-001.svg

These test for support for references to general shapes (rather than just paths) from <textPath>. We don't support that yet.

external/wpt/svg/text/reftests/textpath-side-001.svg

This tests for support for textPath@side, which we also does not support.

These latter two features are covered by issue 366559, so given the uncertainty of the first item I'd suggest duping this into that issue unless anyone has a better suggestion.
Go ahead and dupe.

In general I think we should note the related test on the bug and then Skip it.
Owner: f...@opera.com
Status: Assigned (was: Untriaged)
On second thought, fs@ could you please add the failing test info for the things we don't support into the tracking bug for that i.e. 366559, then mark this as available for the other failure.

You may also need to update the bug number in TestExpectations if these files appear there.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0cb9b2c384267d5394f387667271c856245a63e

commit e0cb9b2c384267d5394f387667271c856245a63e
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Aug 13 10:29:09 2018

Update bug references for some failing SVG WPT tests

These tests fail because of lack of support for references to general
shapes from <textPath> and the 'side' attribute in <textPath>.
crbug.com/366559 is the bug for supporting thos features, so redirect to
it.

Tests:

  external/wpt/svg/shapes/reftests/pathlength-003.svg
  external/wpt/svg/text/reftests/textpath-side-001.svg
  external/wpt/svg/text/reftests/textpath-shape-001.svg

TBR=schenney@chromium.org
BUG=366559,863355

Change-Id: Ia2fc56704fafd3ace0af949fceeaf2799f960fe7
Reviewed-on: https://chromium-review.googlesource.com/1172298
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#582542}
[modify] https://crrev.com/e0cb9b2c384267d5394f387667271c856245a63e/third_party/WebKit/LayoutTests/TestExpectations

Owner: ----
Status: Available (was: Assigned)
Summary: external/wpt/svg/shapes/reftests/pathlength-002.svg has subpixel differences on Mac (was: [WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1136223)
I hope the commit message I wrote should suffice for "failing test info".
Labels: OS-Mac
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c70ff96f05aecbb14e81cfc32bbef8829c684dc

commit 2c70ff96f05aecbb14e81cfc32bbef8829c684dc
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Aug 13 13:41:58 2018

Update bugref for external/wpt/svg/shapes/reftests/pathlength-002.svg

TBR=schenney@chromium.org
BUG=863355

Change-Id: Ib58518bb68af39fb5e106cb0da0f08df5e6a832a
Reviewed-on: https://chromium-review.googlesource.com/1172361
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#582565}
[modify] https://crrev.com/2c70ff96f05aecbb14e81cfc32bbef8829c684dc/third_party/WebKit/LayoutTests/TestExpectations

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment