New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863350 link

Starred by 1 user
Status: Fixed
Owner:
█ kraynov@chromium.org
Xoogler
Closed: Jul 17
Cc:
skyos...@chromium.org
altimin@chromium.org
gab@chromium.org
█ alexclarke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Remove cc::OrderedSimpleTaskRunner completely

Project Member Reported by kraynov@chromium.org, Jul 13 
It's already removed from the most places (see  https://crbug.com/841735 ), now it's time to remove it completely.

Tests still using it:
cc/scheduler/scheduler_unittest.cc
cc/test/scheduler_test_common.cc
components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
components/viz/common/frame_sinks/begin_frame_source_unittest.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ab73342d36e6ee13e181269eb1284edfcd14bb5

commit 3ab73342d36e6ee13e181269eb1284edfcd14bb5
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jul 13 15:56:43 2018

Remove cc::OrderedSimpleTaskRunner from DirectLayerTreeFrameSink tests.

Bug:  863350 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7f4ade68fd7d504d06f276660e66ee7c01f20806
Reviewed-on: https://chromium-review.googlesource.com/1136549
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574932}
[modify] https://crrev.com/3ab73342d36e6ee13e181269eb1284edfcd14bb5/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0922ce85a02925b0bbf00fa5985196f755264243

commit 0922ce85a02925b0bbf00fa5985196f755264243
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jul 16 14:00:00 2018

Remove cc::OrderedSimpleTaskRunner from BeginFrameSource tests.

Bug:  863350 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9b039766d0fdf3fa5a0f261c4145a4f690d62c4f
Reviewed-on: https://chromium-review.googlesource.com/1138245
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575244}
[modify] https://crrev.com/0922ce85a02925b0bbf00fa5985196f755264243/components/viz/common/frame_sinks/begin_frame_source_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3990845fcd75ad46c8391f459f37ff7bbcff9fc1

commit 3990845fcd75ad46c8391f459f37ff7bbcff9fc1
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Jul 17 12:00:24 2018

Remove cc::OrderedSimpleTaskRunner from //cc/scheduler tests.

Bug:  863350 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74b5ab9428ec1b5452c374f4c9dccea7e26612ab
Reviewed-on: https://chromium-review.googlesource.com/1138313
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575610}
[modify] https://crrev.com/3990845fcd75ad46c8391f459f37ff7bbcff9fc1/cc/scheduler/scheduler_unittest.cc
[modify] https://crrev.com/3990845fcd75ad46c8391f459f37ff7bbcff9fc1/cc/test/scheduler_test_common.cc
[modify] https://crrev.com/3990845fcd75ad46c8391f459f37ff7bbcff9fc1/cc/test/scheduler_test_common.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93203a98d131db49fecd564427bd3204bbf50acf

commit 93203a98d131db49fecd564427bd3204bbf50acf
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Jul 17 12:09:04 2018

Remove cc::OrderedSimpleTaskRunner \o/.

Long live base::TestMockTimeTaskRunner.

Bug:  863350 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id3df59c1fb1588e95e0135c7c6a90cfad47d29f1
Reviewed-on: https://chromium-review.googlesource.com/1140062
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575612}
[modify] https://crrev.com/93203a98d131db49fecd564427bd3204bbf50acf/components/viz/test/BUILD.gn
[delete] https://crrev.com/607bb7d369bc655566f3363f744e8418eb753107/components/viz/test/ordered_simple_task_runner.cc
[delete] https://crrev.com/607bb7d369bc655566f3363f744e8418eb753107/components/viz/test/ordered_simple_task_runner.h
[delete] https://crrev.com/607bb7d369bc655566f3363f744e8418eb753107/components/viz/test/ordered_simple_task_runner_unittest.cc

Comment 5 by kraynov@chromium.org, Jul 17

Status: Fixed (was: Assigned)
It's gone \o/

Comment 6 by altimin@chromium.org, Jul 17 

Great, thanks!

Comment 7 by gab@chromium.org, Jul 17 

Woohooo! Thanks!
►

Sign in to add a comment