New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863335 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jul 19
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Ghost text is seen chopped when font size changes to 'very large'

Reported by pranjali...@etouch.net, Jul 13 
Chrome version : 69.0.3489.0 (Official Build) 66d7b6411564744a0d3589943331a0a7db096a3d-refs/branch-heads/3489@{#1}(32/64-bit) 

OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Steps to reproduce:
1. Launch chrome and change font size to 'very large'.
2. Now click on 'Add Languages' under Language and observe 'Search languages' textbox.

Actual Result: Ghost text is seen chopped when font size changes to 'very large'
Expected Result:  Ghost text should not be seen chopped when font size changes to 'very large' instead text continuation should be seen.

This is a regression issue broken in ‘M-69’ and below is bisect info.
Good build: 69.0.3456.0
Bad build: 69.0.3457.0

You are probably looking for a change made after 566530 (known good), but no later than 566531 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/8f68ca7f55a3606bf2a3c4ae836471a2f0536f3b..a28431dbf4972895460f4a085da668eb7e255826

Suspect:https://chromium.googlesource.com/chromium/src/+/a28431dbf4972895460f4a085da668eb7e255826

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You
Actual_result.png
122 KB View Download
Expected_result.png
128 KB View Download

Comment 1 by stsl1981...@gmail.com, Jul 13 

863335

Comment 2 by scottchen@chromium.org, Jul 16

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d4dc6bad90ff3dacdfdcdc3e8e5a8e17fd20071

commit 7d4dc6bad90ff3dacdfdcdc3e8e5a8e17fd20071
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Jul 19 21:10:09 2018

Settings: fix settings-subpage-search placeholder being chopped.

settings-subpage-search originally was reserving 20px at the end for the
'x' button, but when there's no input, the placeholder was seen to be
chopped at the 20px padding and looks strange.

This CL makes it so that it only adds the 20px padding when there's text
and 'x' button is visible.

Bug:  863335 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0440b9ef3904e8c1d7180de4f3814b4c2020588b
Reviewed-on: https://chromium-review.googlesource.com/1138819
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576626}
[modify] https://crrev.com/7d4dc6bad90ff3dacdfdcdc3e8e5a8e17fd20071/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Comment 4 by dpa...@chromium.org, Jul 19

Status: Fixed (was: Started)

Comment 5 by pranjali...@etouch.net, Jul 20

Labels: TE-Verified-69.0.3497.0 TE-Verified-M69
Update:

Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS using latest canary build#69.0.3497.0 and issue is fixed. ghost text is not seen chopped after changing font size to 'very large'.

Please find below attached screencast for reference.

Thank You...
Canary Behaviour.mp4
459 KB View Download
►

Sign in to add a comment