Add padding for history.google.com disclaimer in History |
|||||
Issue descriptionAdd 13pt Padding for history.google.com disclaimer in History. See Attachment.
,
Jul 13
+cc:thegreenfrog@ in case you have extra time.
,
Jul 17
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea45f07fd2fcd624666fe19021e6e5223f56eb0 commit 9ea45f07fd2fcd624666fe19021e6e5223f56eb0 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Jul 17 23:53:17 2018 [ios] Fix TableViewTextLinkCell Label Spacing - Increases top spacing to 13px - Decreases bottom spacing to 0px so that the vertical spacing between footnote labels in Clear Browsing Data is not massive. Screenshots: https://drive.google.com/open?id=12DY7uMoFwu0qpy93N3nUEdsBPIDeaJlQ, https://drive.google.com/open?id=1XARsG_J1dvUu1gSDVBJW4qTfPVMTp8mN Bug: 863330 Change-Id: I92b7b4d09617353d6ccba088ea8fa3675b32c986 Reviewed-on: https://chromium-review.googlesource.com/1141056 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#575851} [modify] https://crrev.com/9ea45f07fd2fcd624666fe19021e6e5223f56eb0/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/9ea45f07fd2fcd624666fe19021e6e5223f56eb0/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/9ea45f07fd2fcd624666fe19021e6e5223f56eb0/ios/chrome/browser/ui/table_view/cells/table_view_text_link_item.mm
,
Jul 18
,
Jul 31
Verified in: App Version: 70.0.3508.0 canary Devices: iPhone 6 Plus, iPhone 8 Plus, iPad Air iOS Versions: 11.4.1, 12.0 beta 5 Increased top spacing or padding for history.google.com disclaimer in History. Please refer to screenshot
,
Jul 31
Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by marq@chromium.org
, Jul 13Status: Assigned (was: Untriaged)