New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863309 link

Starred by 1 user
Status: Verified
Owner:
fbeaufort@chromium.org
Closed: Aug 13
Cc:
ajha@chromium.org
█ apaci...@chromium.org
y...@chromium.org
liber...@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Black screen is seen while playing the video in Picture-in-Picture of camera app

Project Member Reported by rkalavakuntla@chromium.org, Jul 13 
Chrome Version:69.0.3486.0/10866.1.0 dev channel Daisy,Kip,Paine
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build >> Sign into user >>Open camera app
(2)Do a sample video recording >> go to Gallery >>open it
(3)click three dot menu >>select Picture-in-Picture
(4)Play the video in Picture-in-Picture and observe

Actual:Black screen is seen while playing the video in Picture-in-Picture
Expected: Video should be seen clear while playing the video in Picture-in-Picture

Raising this as a Non-Regression issue seen from 69.0.3486.0/10866.1.0 dev

Attached the screencast for reference..
Actual.mp4
15.1 MB Download

Comment 1 by rkalavakuntla@chromium.org, Jul 18

Cc: beaufort...@gmail.com liber...@chromium.org
beaufort.francois@/liberato@ : Could you please confirm whether the  Issue 864488  is similar to this issue. 
Thanks.

Comment 2 by liber...@chromium.org, Jul 18

Owner: apaci...@chromium.org
Status: Assigned (was: Untriaged)
i don't see enough to say it's a duplicate.  => apacible for triage.  i assume this is the same pip (we have so many :) )

Comment 3 by apaci...@chromium.org, Jul 18

Components: Blink>Media>PictureInPicture

Comment 4 by fbeaufort@chromium.org, Jul 18

Cc: mlamouri@chromium.org
MediaStreams are not supported yet. We should disable PiP button for now. WDYT apacible@ mlamouri@?

Comment 5 by apaci...@chromium.org, Jul 18 

Yes, we should disable PiP button until MediaStreams is supported.

Comment 6 by fbeaufort@chromium.org, Jul 20

Cc: -beaufort...@gmail.com apaci...@chromium.org
Owner: fbeaufort@chromium.org
That's my fault. I'll fix it.

Comment 7 by fbeaufort@chromium.org, Jul 20 

I'm not sure this is MediaStreams related actually.
I'll continue investigating.

Comment 8 by mlamouri@chromium.org, Jul 27 

Is this still reproducible?

Comment 9 by rkalavakuntla@chromium.org, Jul 30 

Able to reproduce the issue on latest available ToT - 70.0.3505.0/10920.0.0 dev 
Thanks!

Comment 10 by fbeaufort@chromium.org, Jul 31 

Picture-in-Picture is not supported in Chrome Apps yet. I'll work on a fix to address this issue. See WIP at https://chromium-review.googlesource.com/c/chromium/src/+/1145261
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e031e566fb77330da96a1415a3d08a908cc43a6e

commit e031e566fb77330da96a1415a3d08a908cc43a6e
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Fri Aug 03 10:37:19 2018

Enable Picture-in-Picture for chrome apps.

This CL enables Picture-in-Picture in chrome apps by implementing
EnterPictureInPicture and ExitPictureInPicture in AppDelegate.

Bug:  863309 
Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
Reviewed-on: https://chromium-review.googlesource.com/1156513
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580497}
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/browser/apps/platform_apps/app_browsertest.cc
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/browser/ui/apps/chrome_app_delegate.h
[add] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/test/data/extensions/platform_apps/picture_in_picture/bear.webm
[add] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/test/data/extensions/platform_apps/picture_in_picture/main.html
[add] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/test/data/extensions/platform_apps/picture_in_picture/main.js
[add] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/test/data/extensions/platform_apps/picture_in_picture/manifest.json
[add] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/chrome/test/data/extensions/platform_apps/picture_in_picture/test.js
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/extensions/browser/app_window/app_delegate.h
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/extensions/shell/browser/shell_app_delegate.cc
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/extensions/shell/browser/shell_app_delegate.h
[modify] https://crrev.com/e031e566fb77330da96a1415a3d08a908cc43a6e/testing/buildbot/filters/mash.browser_tests.filter

Comment 13 by fbeaufort@chromium.org, Aug 13

Status: Verified (was: Assigned)
Verified in Chrome 70.0.3519.3 (Official Build) canary (64-bit)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8

commit f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8
Author: Nico Weber <thakis@chromium.org>
Date: Sun Aug 19 23:40:47 2018

Run browser_tests (and viz_browser_tests) on win/asan bot.

- PlatformAppBrowserTest.PictureInPicture consistently fails with a
  (apparently windows-only) use-after-free on win/asan. That code is new,
  so just revert it (see below),  https://crbug.com/873234 

- PDFExtensionHitTestTest.MouseLeave flakes fairly often on win/asan, so
  disable the test in that config, https://crbug.com/856169

- SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0
  fails fairly consistenly on win/asan (and elsewhere) in
  network_service_browser_tests, so don't enable that suite on the win/asan
  bot just yet (https://crbug.com/840063).

Bug:  869973 

Revert "Enable Picture-in-Picture for chrome apps."

This reverts commit e031e566fb77330da96a1415a3d08a908cc43a6e.

Reason for revert: Test has a use-after-free,  https://crbug.com/873234 

Original change's description:
> Enable Picture-in-Picture for chrome apps.
>
> This CL enables Picture-in-Picture in chrome apps by implementing
> EnterPictureInPicture and ExitPictureInPicture in AppDelegate.
>
> Bug:  863309 
> Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
> Reviewed-on: https://chromium-review.googlesource.com/1156513
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580497}

TBR=beaufort.francois@gmail.com,rdevlin.cronin@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  863309 
Change-Id: Ib6eda55a3b0889646c43ea3e7bfccdb590cea0b2
Reviewed-on: https://chromium-review.googlesource.com/1180763
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584347}
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/apps/platform_apps/app_browsertest.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/chrome/browser/ui/apps/chrome_app_delegate.h
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/bear.webm
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/main.html
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/main.js
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/manifest.json
[delete] https://crrev.com/66d7422952a234bc2a822ca9150241b8fe6d90a4/chrome/test/data/extensions/platform_apps/picture_in_picture/test.js
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/browser/app_window/app_delegate.h
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/shell/browser/shell_app_delegate.cc
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/extensions/shell/browser/shell_app_delegate.h
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/f4d9a36a0da1bcc4d9ceba6e39c8ff6768500cf8/testing/buildbot/test_suite_exceptions.pyl
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e233fdf01cf907805451746b48a6a05348ac856

commit 1e233fdf01cf907805451746b48a6a05348ac856
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Aug 28 11:02:32 2018

Reland "Enable Picture-in-Picture for chrome apps."

This CL enables Picture-in-Picture in chrome apps by implementing
EnterPictureInPicture and ExitPictureInPicture in AppDelegate.

Bug:  863309 
Change-Id: I67ddd28ad84c658b0ce992be7ef8cbff3f1a9f9e
Reviewed-on: https://chromium-review.googlesource.com/1181124
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586649}
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/browser/apps/platform_apps/app_browsertest.cc
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/browser/ui/apps/chrome_app_delegate.h
[add] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/test/data/extensions/platform_apps/picture_in_picture/bear.webm
[add] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/test/data/extensions/platform_apps/picture_in_picture/main.html
[add] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/test/data/extensions/platform_apps/picture_in_picture/main.js
[add] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/test/data/extensions/platform_apps/picture_in_picture/manifest.json
[add] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/chrome/test/data/extensions/platform_apps/picture_in_picture/test.js
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/extensions/browser/app_window/app_delegate.h
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/extensions/shell/browser/shell_app_delegate.cc
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/extensions/shell/browser/shell_app_delegate.h
[modify] https://crrev.com/1e233fdf01cf907805451746b48a6a05348ac856/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
►

Sign in to add a comment