New issue
Advanced search Search tips

Issue 863295 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Timeout in pdf_cfx_barcode_fuzzer

Project Member Reported by ClusterFuzz, Jul 13

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5215416625135616

Fuzzer: libFuzzer_pdf_cfx_barcode_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_cfx_barcode_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=574744:574745

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5215416625135616

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: kkaluri@chromium.org
Components: Internals>Plugins>PDF
Labels: M-69 Test-Predator-Wrong CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.

Thank You...
Blocking: 62400
Labels: -Pri-1 -M-69 -CF-NeedsTriage Pri-2
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
This is XFA related.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/a97a660d47cd500a00f69ad429de0ca1551c7198

commit a97a660d47cd500a00f69ad429de0ca1551c7198
Author: Ryan Harrison <rharrison@chromium.org>
Date: Tue Jul 17 17:25:47 2018

Reserve space for result in ::FilterContents

This changes the implementation for the specific bug listed and
proactively fixes it in the other overrides. The general bug here is
that if you concat a WideString in a tight loop without first
reserving space, each call will cause an allocation size change and
memcpy. This is very expensive and causes ClusterFuzz cases to
timeout.

BUG= chromium:863295 

Change-Id: I6c1d900a31b98cd9ddcf91d1ec0f3973c9cdfa26
Reviewed-on: https://pdfium-review.googlesource.com/38110
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/a97a660d47cd500a00f69ad429de0ca1551c7198/fxbarcode/oned/BC_OnedEAN8Writer.cpp
[modify] https://crrev.com/a97a660d47cd500a00f69ad429de0ca1551c7198/fxbarcode/oned/BC_OnedCodaBarWriter.cpp
[modify] https://crrev.com/a97a660d47cd500a00f69ad429de0ca1551c7198/fxbarcode/oned/BC_OnedUPCAWriter.cpp
[modify] https://crrev.com/a97a660d47cd500a00f69ad429de0ca1551c7198/fxbarcode/oned/BC_OnedCode39Writer.cpp
[modify] https://crrev.com/a97a660d47cd500a00f69ad429de0ca1551c7198/fxbarcode/oned/BC_OnedEAN13Writer.cpp

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216214695b50b7bcb3cec2d6be7afd4d56db45a0

commit 216214695b50b7bcb3cec2d6be7afd4d56db45a0
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 17 18:53:53 2018

Roll src/third_party/pdfium ff402c2c4ce8..a97a660d47cd (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/ff402c2c4ce8..a97a660d47cd


git log ff402c2c4ce8..a97a660d47cd --date=short --no-merges --format='%ad %ae %s'
2018-07-17 rharrison@chromium.org Reserve space for result in ::FilterContents


Created with:
  gclient setdep -r src/third_party/pdfium@a97a660d47cd

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:863295 
TBR=dsinclair@chromium.org

Change-Id: If9d901d30f2c836e6f849a5e960deb99710f4582
Reviewed-on: https://chromium-review.googlesource.com/1140534
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575735}
[modify] https://crrev.com/216214695b50b7bcb3cec2d6be7afd4d56db45a0/DEPS

Project Member

Comment 7 by ClusterFuzz, Jul 18

ClusterFuzz has detected this issue as fixed in range 575730:575738.

Detailed report: https://clusterfuzz.com/testcase?key=5215416625135616

Fuzzer: libFuzzer_pdf_cfx_barcode_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_cfx_barcode_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=574744:574745
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=575730:575738

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5215416625135616

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 18

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5215416625135616 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment