New issue
Advanced search Search tips

Issue 863264 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jul 16
Cc:
sdy@chromium.org
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-09-03
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MacViews: Packaged App windows don't have rounded bottom corners

Project Member Reported by tapted@chromium.org, Jul 13 
Chrome Version       : 69.0.3488.0

What steps will reproduce the problem?
0. chrome://flags/#views-browser-windows enabled
1. Open a packaged app.

E.g.

Google Keep: https://chrome.google.com/webstore/detail/google-keep-notes-and-lis/hmjkmjkepdijhoojdojkdfohbdgmmhki?hl=en

Chrome remote desktop: https://chrome.google.com/webstore/detail/chrome-remote-desktop/gbchcmhmhahfdphkhkmpfmihenigjmpp

This makes Keep look worse and CRD look better. I dunno if it's worth fixing considering packaged apps are deprecated, and clipping the bottom corners of apps on mac is different to what we do for them on all other platforms.

Either way, sdy probably knows in a heartbeat how to fix.. 

Code lives in https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm?q=native_app_window_views_mac.mm&sq=package:chromium&dr
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9f97f021be825e8470317d60b7e664fa391932d

commit f9f97f021be825e8470317d60b7e664fa391932d
Author: Sidney San Martín <sdy@chromium.org>
Date: Fri Jul 13 20:21:07 2018

Fix missing rounded corners on MacViews app windows.

Two changes:

- Make all Views windows layer backed (they mostly were already).

- Use _titlebarHeight to hide the titlebar for app windows. _hidingTitlebar
  resulted in the top corners not being clipped (as if the window were a
  sheet).

Bug:  863264 ,  862672 
Change-Id: I9647afdcba464cc17b88cc2d752bf273a0f6ab89
Reviewed-on: https://chromium-review.googlesource.com/1136520
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575047}
[modify] https://crrev.com/f9f97f021be825e8470317d60b7e664fa391932d/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm
[modify] https://crrev.com/f9f97f021be825e8470317d60b7e664fa391932d/ui/views/cocoa/bridged_native_widget.mm

Comment 2 by swarnasree.mukkala@chromium.org, Jul 16

Labels: Needs-Feedback
Unable to reproduce the issue on reported version 69.0.3488.0 on Mac 10.13.5 by following below steps.
1.Launched chrome and enabled the #views-browser-windows 
2. Opened the packaged App-Google Keep. But could observe the rounded bottom corners.

Attached the screenshots for reference.
@sdy - Could you please help us in confirming the fix.
Thanks.!
69.0.3493.0.png
204 KB View Download
69.0.3488.0.png
228 KB View Download

Comment 3 by sdy@chromium.org, Jul 16

NextAction: 2018-09-03
Status: Fixed (was: Untriaged)
tapted@: I'm not sure about the right behavior either. Some apps definitely look better without rounded corners. I've also seen Electron apps that keep rounded corners *and* the native window buttons (but no separate title bar), which is a much easier style to achieve on Mac than rounded corners and no native controls — no hacks needed. Maybe good to revisit?

Comment 4 by sdy@chromium.org, Jul 16 

Re. #2, I'm not sure why it didn't repro for you :/.

Comment 5 by tapted@chromium.org, Jul 17 

#c3: I think the way forward is PWAs, which are "just" a browser window. Except we may be looking to move location bar decorations into the titlebar like we're doing on ChromeOS. So, back to hacks.

I don't think we'll ever want to support frameless windows (again), since they can remove security UI.

Comment 6 by monor...@bugs.chromium.org, Sep 3 

The NextAction date has arrived: 2018-09-03
►

Sign in to add a comment