New issue
Advanced search Search tips

Issue 863250 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jul 13
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ResourceLoadingHintsBrowserTest.ResourceLoadingHintsHttpsNoWhitelisted" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 12 
"ResourceLoadingHintsBrowserTest.ResourceLoadingHintsHttpsNoWhitelisted" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUQsSBUZsYWtlIkZSZXNvdXJjZUxvYWRpbmdIaW50c0Jyb3dzZXJUZXN0LlJlc291cmNlTG9hZGluZ0hpbnRzSHR0cHNOb1doaXRlbGlzdGVkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by kpaulhamus@chromium.org, Jul 13

Owner: tbansal@chromium.org
Status: Assigned (was: Untriaged)
Hi Tauran, there still seem to be some flaky tests. Can you take a look?

Comment 2 by tbansal@chromium.org, Jul 13

Components: Blink>Previews
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d5801a95b37150a536045251b135a038ba12e6e

commit 3d5801a95b37150a536045251b135a038ba12e6e
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Jul 13 19:17:12 2018

Fix resource loading hints flaky test

Make the test wait for resource loading hints to be available.

Change-Id: I4b0cd3d3f03c53efcd386f16c6e70d05d9ef2ed4
Bug:  863250 
Reviewed-on: https://chromium-review.googlesource.com/1136838
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575011}
[modify] https://crrev.com/3d5801a95b37150a536045251b135a038ba12e6e/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

Comment 4 by kpaulhamus@chromium.org, Jul 13

Labels: -Sheriff-Chromium

Comment 5 by tbansal@chromium.org, Jul 13

Status: Fixed (was: Started)
Tentatively marking as fixed. If it's still flaky, we would need to disable the test on OS_WIN. The feature is going to be enabled only on Android, so as long as browser tests are enabled on Linux, we should be safe.
►

Sign in to add a comment