New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863243 link

Starred by 1 user
Status: Fixed
Owner:
█ kbr@chromium.org
OOO until 2019-01-24
Closed: Jul 13
Cc:
█ kbr@chromium.org
sky@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocking:
issue 775644



Sign in to add a comment

WebGL DCHECK failures: FATAL:usage_clock.cc(46)] Check failed: IsInUse()

Project Member Reported by jdarpinian@chromium.org, Jul 12 
I'm seeing a ton of failures on win_optional_gpu_tests_rel with this DCHECK failing. Here's an example build:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_optional_gpu_tests_rel/4889

Comment 1 by jdarpinian@chromium.org, Jul 12 

I suspect this CL or one of several others submitted today by the same person: https://chromium-review.googlesource.com/c/chromium/src/+/1133593

Comment 2 by jdarpinian@chromium.org, Jul 12

Cc: fdoray@chromium.org

Comment 3 by kbr@chromium.org, Jul 12 

Stack trace:

[7528:7340:0712/154521.532:FATAL:usage_clock.cc(46)] Check failed: IsInUse(). 
Backtrace:
	base::debug::StackTrace::StackTrace [0x71633030+32]
	base::debug::StackTrace::StackTrace [0x7163282D+13]
	logging::LogMessage::~LogMessage [0x7164CCF3+83]
	resource_coordinator::UsageClock::OnSessionEnded [0x7297EDA3+83]
	metrics::DesktopSessionDurationTracker::EndSession [0x7277E921+183]
	metrics::DesktopSessionDurationTracker::OnTimerFired [0x7277EE83+271]
	base::Timer::RunScheduledTask [0x71696895+245]
	base::debug::TaskAnnotator::RunTask [0x71CD7522+306]
	base::MessageLoop::RunTask [0x71656903+467]
	base::MessageLoop::DeferOrRunPendingTask [0x71656C5D+157]
	base::MessageLoop::DoDelayedWork [0x71657361+881]
	base::MessagePumpForUI::DoRunLoop [0x71658E1D+141]
	base::MessagePumpWin::Run [0x71658991+65]
	base::MessageLoop::Run [0x71656457+119]
	base::RunLoop::Run [0x71678DFC+204]
	ChromeBrowserMainParts::MainMessageLoopRun [0x7220F382+190]
	content::BrowserMainLoop::RunMainMessageLoopParts [0x70F45B79+59]
	content::BrowserMainRunnerImpl::Run [0x70F48004+142]
	content::BrowserMain [0x70F42AB5+157]
	content::RunBrowserProcessMain [0x715FB070+84]
	content::ContentMainRunnerImpl::Run [0x715FB7CE+680]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x715FADF7+19]
	service_manager::Main [0x716056DC+1384]
	content::ContentMain [0x715FAFF3+51]
	ChromeMain [0x707D119C+288]
	MainDllLoader::Launch [0x00F95790+560]
	wWinMain [0x00F91543+1347]
	__scrt_common_main_seh [0x0106CAAA+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	BaseThreadInitThunk [0x76F88744+36]
	RtlGetAppContainerNamedObjectPath [0x776F58ED+253]
	RtlGetAppContainerNamedObjectPath [0x776F58BD+205]

Comment 4 by kbr@chromium.org, Jul 12

Blocking: 775644
Labels: -Type-Bug Type-Bug-Regression

Comment 5 by kbr@chromium.org, Jul 12

Cc: sky@chromium.org
Another failure, this time on a bot which doesn't have DCHECKs enabled:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28Intel%20HD%20630%29/4191

https://chromium-swarm.appspot.com/task?id=3ea97792e91f5d10&refresh=10&show_raw=1

  	Crash reason:  SIGABRT
  	Crash address: 0x3e800006525
  	Process uptime: not available
  	
  	Thread 0 (crashed)
  	 0  libc-2.24.so + 0x3577f
  	    rax = 0x0000000000000000   rdx = 0x0000000000000000
  	    rcx = 0x00007fd24f0ac77f   rbx = 0x0000000000000019
  	    rsi = 0x00007ffdd98b7ee0   rdi = 0x0000000000000002
  	    rbp = 0x00007ffdd98b8120   rsp = 0x00007ffdd98b7f58
  	     r8 = 0x0000000000000000    r9 = 0x00007ffdd98b7ee0
  	    r10 = 0x0000000000000008   r11 = 0x0000000000000246
  	    r12 = 0x00007ffdd98b85e0   r13 = 0x00007ffdd98b85d0
  	    r14 = 0x00007ffdd98b85d8   r15 = 0x000011c9a917ba53
  	    rip = 0x00007fd24f0ac77f
  	    Found by: given as instruction pointer in context
  	 1  chrome!~LogMessage [callback.h : 129 + 0x7]
  	    rbp = 0x00007ffdd98b85c0   rsp = 0x00007ffdd98b8130
  	    rip = 0x000055bc7a076faf
  	    Found by: previous frame's frame pointer
  	 2  chrome!OnSessionEnded [usage_clock.cc : 46 + 0x8]
  	    rbx = 0x000011c9a84561c8   rbp = 0x00007ffdd98b8710
  	    rsp = 0x00007ffdd98b85d0   r12 = 0x00007ffdd98b8768
  	    r13 = 0x000055bc75a9d57d   r14 = 0x00007ffdd98b85d0
  	    r15 = 0x000011c9a84561c8   rip = 0x000055bc79f21845
  	    Found by: call frame info
  	 3  chrome!EndSession [desktop_session_duration_tracker.cc : 154 + 0x9]
  	    rbx = 0x00007ffdd98b8740   rbp = 0x00007ffdd98b88c0
  	    rsp = 0x00007ffdd98b8720   r12 = 0x00007ffdd98b8768
  	    r13 = 0x000055bc75a9d57d   r14 = 0x00007ffdd98b8720
  	    r15 = 0x000011c9a84561c8   rip = 0x000055bc79ef9795
  	    Found by: call frame info
  	 4  chrome!OnTimerFired [desktop_session_duration_tracker.cc : 127 + 0x8]
  	    rbx = 0x000011c9a80466e0   rbp = 0x00007ffdd98b8a10
  	    rsp = 0x00007ffdd98b88d0   r12 = 0x0000000000000000
  	    r13 = 0x00007ffdd98b92c0   r14 = 0x000011c9a92600b0
  	    r15 = 0x000055bc79ef9e40   rip = 0x000055bc79ef9f03
  	    Found by: call frame info
  	 5  chrome!Run [bind_internal.h : 507 + 0x14]
  	    rbx = 0x000011c9a9260080   rbp = 0x00007ffdd98b8b70
  	    rsp = 0x00007ffdd98b8a20   r12 = 0x0000000000000000
  	    r13 = 0x00007ffdd98b92c0   r14 = 0x000011c9a92600b0
  	    r15 = 0x000055bc79ef9e40   rip = 0x000055bc776defd4
  	    Found by: call frame info
  	 6  chrome!RunScheduledTask [callback.h : 129 + 0x3]
  	    rbx = 0x000011c9a8046708   rbp = 0x00007ffdd98b8cc0
  	    rsp = 0x00007ffdd98b8b80   r12 = 0x000011c9a7d02828
  	    r13 = 0x00007ffdd98b92c0   r14 = 0x0000000000000000
  	    r15 = 0x000055bc7f482e10   rip = 0x000055bc7a0fef71
  	    Found by: call frame info
  	 7  chrome!RunTask [callback.h : 99 + 0x3]
  	    rbx = 0x000055bc7fb4c220   rbp = 0x00007ffdd98b8ed0
  	    rsp = 0x00007ffdd98b8cd0   r12 = 0x000011c9a7d02828
  	    r13 = 0x00007ffdd98b92c0   r14 = 0x0000000000000000
  	    r15 = 0x000055bc7f482e10   rip = 0x000055bc7a07f9bd
  	    Found by: call frame info
  	 8  chrome!RunTask [message_loop.cc : 454 + 0xf]
  	    rbx = 0x000011c9a7ce88c0   rbp = 0x00007ffdd98b90e0
  	    rsp = 0x00007ffdd98b8ee0   r12 = 0x000055bc7f482dc0
  	    r13 = 0x00007ffdd98b92c0   r14 = 0x000055bc7fb4eabc
  	    r15 = 0x000055bc79ef92d6   rip = 0x000055bc7a07e036
  	    Found by: call frame info
  	 9  chrome!DeferOrRunPendingTask [message_loop.cc : 465 + 0xb]
  	    rbx = 0x00007ffdd98b92c0   rbp = 0x00007ffdd98b92a0
  	    rsp = 0x00007ffdd98b90f0   r12 = 0x00007ffdd98b9320
  	    r13 = 0x000011c9a7dbbe40   r14 = 0x000011c9a7ce88c0
  	    r15 = 0x000011c9a7ce88c0   rip = 0x000055bc7a07e44a
  	    Found by: call frame info
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1462acffad5f9eeb4229aac3a655f276f98f1ea5

commit 1462acffad5f9eeb4229aac3a655f276f98f1ea5
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Jul 12 23:42:17 2018

Revert "RC: Record Chrome usage time when a LifecycleUnit is hidden."

This reverts commit 840dc0a7c0eacb82070efe833ef3aacc7b2e89cb.

Revert "RC: Use Chrome usage time since hidden to decide if tab can be proactively discarded."

This reverts commit 3c279f295bc8924c82ed072f564ac9fe8fa3c8aa.

Revert "RC: Move parts of TabManager::PerformStateTransitions() into helper methods."

This reverts commit 79fba7433e865da18a2726f058eb21a2f000ca90.

These three CLs stack on top of each other and the first one (
840dc0a7c0eacb82070efe833ef3aacc7b2e89cb ,
https://chromium-review.googlesource.com/1133593 ) seems to have
introduced assertion failures and crashes per  http://crbug.com/863243  .

Tbr: fdoray@chromium.org
Tbr: sky@chromium.org
Bug: 775644,  863243 
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7f02f28de26a8c531e6eebe847120f45b133fd7d
Reviewed-on: https://chromium-review.googlesource.com/1135969
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574775}
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/lifecycle_unit.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/lifecycle_unit_base.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/lifecycle_unit_base.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/lifecycle_unit_base_unittest.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_lifecycle_unit.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/test_lifecycle_unit.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/browser/resource_coordinator/test_lifecycle_unit.h
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/1462acffad5f9eeb4229aac3a655f276f98f1ea5/chrome/test/base/testing_browser_process.h

Comment 7 by kbr@chromium.org, Jul 13

Owner: kbr@chromium.org
Status: Assigned (was: Untriaged)
Watching:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_optional_gpu_tests_rel

as this trybot seems to be one which is the worst affected by this issue.

Comment 8 by kbr@chromium.org, Jul 13

Status: Fixed (was: Assigned)
This bot recovered after the reverts above.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cecb37c6133edbb24836f56f8f56667051b9d79

commit 0cecb37c6133edbb24836f56f8f56667051b9d79
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Jul 13 19:36:43 2018

Prevent double end session in DesktopSessionDurationTracker.

Previously, this scenario could cause the same session to end twice:
 - Chrome becomes visible.
 - User event -> Session starts.
 - Chrome becomes hidden -> Session ends.
 - Inactivity timeout expires -> Session ends again.

This CL fixes the issue by stopping the inactivity timer when a
session ends.

Bug:  863243 
Change-Id: I3d903844ab07775ebc5d653f34fa6b91a3623021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1136725
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575021}
[modify] https://crrev.com/0cecb37c6133edbb24836f56f8f56667051b9d79/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.cc
[modify] https://crrev.com/0cecb37c6133edbb24836f56f8f56667051b9d79/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h
[modify] https://crrev.com/0cecb37c6133edbb24836f56f8f56667051b9d79/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
[modify] https://crrev.com/0cecb37c6133edbb24836f56f8f56667051b9d79/chrome/browser/resource_coordinator/usage_clock_unittest.cc
►

Sign in to add a comment