New issue
Advanced search Search tips

Issue 863230 link

Starred by 29 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression

Blocked on:
issue 882065



Sign in to add a comment

GTK+ theme ignored in omnibar in the new interface

Reported by virus.fl...@gmail.com, Jul 12

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/68.0.3440.42 Chrome/68.0.3440.42 Safari/537.36

Steps to reproduce the problem:
I have a dark GTK+ theme (Adwaita Dark). 

What is the expected behavior?

What went wrong?
Screenshot 1 shows Chromium's omnibar in Chromium 68 - it follows system colors - dark background as in the GTK+ theme.

Screenshot 2 shows new UI - it does not follow system colors and destroys my eyes by white background.

Did this work before? N/A 

Chrome version: 69.0.3486.0  Channel: dev
OS Version: 
Flash Version:
 
DeepinScreenshot_выберите-область_20180713015344.png
20.8 KB View Download
DeepinScreenshot_выберите-область_20180713015325.png
29.3 KB View Download
Labels: Needs-Triage-M69
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chromium version 69.0.3486.0  also on latest chrome 69.0.3494.0 using Mac 10.13.5, Ubuntu 17.10 and Windows 10.  

Same behavior is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged.

Thanks! 
I don't remember the status bar to have white background on dark GTK+ themes in chromium version 60... Why is it a non-regression? Is it a design solution? A very bad one, if yes, because it hurts eyes. It's color is OK in version 68, but is not in 69.
To be more exact, it's probably not a regression for the new UI, but as the new UI will become default, it's a regression for user experience.
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Cc: tommycli@chromium.org
Labels: -OS-Windows -Type-Bug -OS-Mac Type-Bug-Regression
+tommicli is the omnibox no longer using the native theme colors?  I'm using the same theme as the OP and I'm seeing the same regression.
Cc: bklmn@chromium.org bettes@chromium.org
Owner: bklmn@chromium.org
Hey Joel / Alan,

What's our plan for respecting native theme colors in MD Refresh?

Tommy
Ping. It's now in Beta, and it's really awful
One more issue: now the contast between the active tab and others is very low, lower than before, it's very hard to find which tab is active.
For anyone who comes here via google/search.
To restore old UI:
chrome://flags/#top-chrome-md


DeepinScreenshot_выберите-область_20180828181502.png
79.9 KB View Download
I too would appreciate a fix. Previously, the omnibar background obeyed gtk.css. Now it doesn't. Having a whtite background when the rest of the page is dark can be a bit of a strain and distracting. Thank you!
20180905095813.png
18.9 KB View Download
Blockedon: 882065
Cc: susan.boorgula@chromium.org
 Issue 884497  has been merged into this issue.
Cc: jdonnelly@chromium.org
 Issue 884199  has been merged into this issue.
Cc: vamshi.kommuri@chromium.org
 Issue 887419  has been merged into this issue.
#15, the workaround is starting to break in dev/canary (buttons are misaligned), and long term I don't have hope that both UIs will be maintained.

So it would be really nice if we at least get a confirmation that this is on the radar for the new UI.
Shouldn't this bug page be updated? We're now a few days into Chrome 70. I remember some years ago that the then project manager, Anthony Laforge,  would punt the milestone involved. Here, we're still seeing M-69.
Here's at least someone from Google in favor of the dark side: https://www.youtube.com/watch?v=N_6sPd0Jd3g titled "Cost of a Pixel Color (Android Dev Summit '18)".
Components: -UI UI>Browser>Omnibox
Owner: ----
Status: Untriaged (was: Assigned)
Kicking this to the omnibox triage queue.

On Linux, when Chrome is in GTK mode, the omnibox colors should be sourced from the native theme.  When it's in Chrome mode, they should be the default built-in colors.

So if these users have set the Chrome settings to GTK mode, this is a bug.
Status: Available (was: Untriaged)
Marking as available; sadly it appears no one will work on it in the next two months.  Contributions welcome!
> So if these users have set the Chrome settings to GTK mode, this is a bug.

Yes, they do have GTK mode.
The #top-chrome-md flag is gone in Version 72.0.3615.0, and there doesnt seem to be a replacement.
I can live with some buttons being off position and hard to click, but i cant live with the glaring white omnibar.
iHQCc4n[1].png
45.2 KB View Download
I agree, the glaring white omnibar is very annoying on dark themes and even more with dark sites.

I'm sorry, that I added no value to this thread, but I feel this thread is being ignored.
Per #21,
> it appears no one will work on it in the next two months.  Contributions welcome!

If you have the time and energy to fix this, I'm sure everyone on this bug would appreciate it.

I'm sorry, I didn't notice that. My fault.

Comment 27 by devwatch...@gmail.com, Dec 6 (6 days ago)

> The #top-chrome-md flag is gone in Version 72.0.3615.0, and there doesnt seem to be a replacement.
Am on stable 71.0.3578.80 and setting the flag #top-chrome-md to "default" doesn't revert the change anymore.
I am sorry to say this but this is really a miss! Please chromium devs, bring it back. I can't/wont use chromium as it is now (ugly).
Screenshots : 
            1- Before the change.
            2- After the change.
Screenshot_20181104_020751.png
22.6 KB View Download
Screenshot_20181206_072457.png
18.3 KB View Download

Comment 28 by thomasanderson@chromium.org, Dec 7 (5 days ago)

Owner: thomasanderson@chromium.org
Status: Started (was: Available)

Comment 29 by andreyvo...@gmail.com, Dec 7 (5 days ago)

Guys. Why need to use so biggest size for folders and bookmarks on bookmarks bar on desktop computers?

Comment 30 by pkasting@chromium.org, Yesterday (45 hours ago)

Cc: pkasting@chromium.org pbos@chromium.org
 Issue 913133  has been merged into this issue.

Sign in to add a comment