New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863216 link

Starred by 2 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Jul 24
Cc:
aee@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Settings: chrome://settings/content sub-page keyboard navigation is difficult

Project Member Reported by aee@chromium.org, Jul 12 
When using keyboard to navigate the sub-pages, upon navigating to the previous page, correct control may not either be in view and/or focused.

Navigate to chrome://settings/content.
Press tab multiple times until clipboard has focus.
Press space/enter which navigates to chrome://settings/content/clipboard.
Press space/enter again. This correctly navigates back to chrome://settings/content.

Expected: the clipboard right arrow button is in view and has focus.
Observed: the clipboard button maybe has focus, but it is not in view.


Navigate to chrome://settings/content/cookies.
Press tab multiple times until the "See all cookies and site data" button has focus.
Press space/enter which navigates to chrome://settings/siteData.
Press space/enter again which navigates back to chrome://settings/content/cookies.

Expected: "See all cookies and site data" button has focus.
Observed: "See all cookies and site data" button does not have focus.


Navigate to chrome://settings/siteData.
Press tab multiple times until a button for one of the site entries has focus.
Press space/enter which navigates to chrome://settings/cookies/detail?site=<site host name>.
Press space/enter again which navigates back to chrome://settings/siteData.

Expected: The sub-page search has focus.
Observed: The sub-page search does not have focus.

Comment 1 by aee@chromium.org, Jul 19

Cc: nyerramilli@chromium.org aee@chromium.org rbasuvula@chromium.org scottchen@chromium.org
 Issue 862986  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46

commit 942c9ea05ff7f10fd9333c25a0c2356dd41d5a46
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Jul 20 00:22:16 2018

Settings: fix focus issues in cookies subpages

Bug:  863216 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie5a01b2ce9f80b6b0569d7c5cd587b9a9d2f642e
Reviewed-on: https://chromium-review.googlesource.com/1135730
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576710}
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/settings_page/BUILD.gn
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/site_settings/site_data.js
[add] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/site_settings/site_data_entry.html
[add] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/site_settings/site_data_entry.js
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/chrome/test/data/webui/settings/site_data_test.js
[modify] https://crrev.com/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46/ui/webui/resources/js/cr/ui/focus_without_ink.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e051dd641abfe1def51ac00286e0c459974fd79e

commit e051dd641abfe1def51ac00286e0c459974fd79e
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jul 20 09:59:31 2018

Revert "Settings: fix focus issues in cookies subpages"

This reverts commit 942c9ea05ff7f10fd9333c25a0c2356dd41d5a46.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 576710 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzk0MmM5ZWEwNWZmN2YxMGZkOTMzM2MyNWEwYzIzNTZkZDQxZDVhNDYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/70402

Sample Failed Step: network_service_interactive_ui_tests

Original change's description:
> Settings: fix focus issues in cookies subpages
> 
> Bug:  863216 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Ie5a01b2ce9f80b6b0569d7c5cd587b9a9d2f642e
> Reviewed-on: https://chromium-review.googlesource.com/1135730
> Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576710}

Change-Id: I159baa28744d96268eef3d496786fe77193c20e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  863216 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1144760
Cr-Commit-Position: refs/heads/master@{#576825}
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/settings_page/BUILD.gn
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/site_settings/site_data.js
[delete] https://crrev.com/d25082cc1a1c035b1056ecaa3efe6cba2ded0e44/chrome/browser/resources/settings/site_settings/site_data_entry.html
[delete] https://crrev.com/d25082cc1a1c035b1056ecaa3efe6cba2ded0e44/chrome/browser/resources/settings/site_settings/site_data_entry.js
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/chrome/test/data/webui/settings/site_data_test.js
[modify] https://crrev.com/e051dd641abfe1def51ac00286e0c459974fd79e/ui/webui/resources/js/cr/ui/focus_without_ink.js
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8129d5f88c296e057165ba1bd74c43ecb270c982

commit 8129d5f88c296e057165ba1bd74c43ecb270c982
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Jul 20 21:36:04 2018

Reland "Settings: fix focus issues in cookies subpages"

And add missing html import.

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1135730

This reverts commit e051dd641abfe1def51ac00286e0c459974fd79e.

Bug:  863216 
Change-Id: I04a4868e1c7b911dade228ba2216667f38ce5de9
Reviewed-on: https://chromium-review.googlesource.com/1145541
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576995}
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/settings_page/BUILD.gn
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/site_settings/site_data.js
[add] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/site_settings/site_data_entry.html
[add] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/site_settings/site_data_entry.js
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/chrome/test/data/webui/settings/site_data_test.js
[modify] https://crrev.com/8129d5f88c296e057165ba1bd74c43ecb270c982/ui/webui/resources/js/cr/ui/focus_without_ink.js

Comment 5 by aee@chromium.org, Jul 24

Status: Fixed (was: Started)
►

Sign in to add a comment