Issue metadata
Sign in to add a comment
|
Transparent webm videos aren't composited with background
Reported by
acmesqua...@gmail.com,
Jul 12
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3486.0 Safari/537.36 Steps to reproduce the problem: 1. https://simpl.info/videoalpha/ What is the expected behavior? The videos have transparent backgrounds, and should be composited with background. What went wrong? Videos have solid black background. Did this work before? No Does this work in other browsers? Yes Chrome version: 69.0.3486.0 Channel: dev OS Version: Flash Version: Adding a no-op css property such as filter:blur(0px) makes videos display correctly. Works in Firefox without this hack.
,
Jul 13
Able to reproduce the issue on chrome version 69.0.3486.0 and latest chrome 69.0.3489.0 using Windows10, Mac OS10.13.5, Ubuntu17.10. Below is the bisect information for same. Bisect Info: ================ Good build: 69.0.3482.0 Bad build: 69.0.3483.0 You are probably looking for a change made after 572792 (known good), but no later than 572793 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/bb1e9dbfa13bfb83892254b2b4ae75279ca58497..9c99a160694b9381543eec592776bf62ab4f77e1 Suspect: https://chromium.googlesource.com/chromium/src/+/9c99a160694b9381543eec592776bf62ab4f77e1 Reviewed-on: https://chromium-review.googlesource.com/1110670 mlamouri:Please confirm the issue and help in re-assigning if it is not related to your change.Adding RB-Stable label for M-68 feel free to change it if not required. Thanks!
,
Jul 13
,
Jul 15
This is a regression coming from using SurfaceLayer for videos. Assigning to lethalantidote@ and CCing the usual group.
,
Jul 15
,
Jul 18
,
Jul 27
lethalantidote@, Friendly ping to get an update on this issue as it is marked as RBS. Thanks..!
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2721137bd2727efcf87febe8b4233c99f3c2bfdf commit 2721137bd2727efcf87febe8b4233c99f3c2bfdf Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Fri Jul 27 23:17:44 2018 Pass the whether the video is opaque to the WebVideoFrameSubmitter. Before, we passed in dummy information that always assumed that the video was opaque. Now we correctly communcate this information such that the video can now be transparent. Bug: 863203 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic4617ef334f01d72ec4c5494d8d9c33accc581db Reviewed-on: https://chromium-review.googlesource.com/1141342 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578850} [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/media/blink/video_frame_compositor.cc [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/media/blink/video_frame_compositor.h [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/media/blink/video_frame_compositor_unittest.cc [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/media/blink/webmediaplayer_impl_unittest.cc [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/third_party/blink/public/platform/web_video_frame_submitter.h [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.cc [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.h [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/third_party/blink/renderer/platform/graphics/video_frame_submitter.h [modify] https://crrev.com/2721137bd2727efcf87febe8b4233c99f3c2bfdf/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
,
Jul 27
,
Jul 27
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 27
Pls request a merge to M69 on Monday once change listed at #8 is baked/verified in canary.
,
Jul 30
The NextAction date has arrived: 2018-07-30
,
Jul 30
Just tried on Canary on a Windows machine and I confirm that after the update, the test page was fixed.
,
Jul 30
Approving merge to M69 branch 3497 based on comment #13. Please merge ASAP,Thank you.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2659be0878db2b3299ee9912757a6b438184f85d commit 2659be0878db2b3299ee9912757a6b438184f85d Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Mon Jul 30 15:44:08 2018 Pass the whether the video is opaque to the WebVideoFrameSubmitter. Before, we passed in dummy information that always assumed that the video was opaque. Now we correctly communcate this information such that the video can now be transparent. Bug: 863203 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic4617ef334f01d72ec4c5494d8d9c33accc581db Reviewed-on: https://chromium-review.googlesource.com/1141342 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578850}(cherry picked from commit 2721137bd2727efcf87febe8b4233c99f3c2bfdf) Reviewed-on: https://chromium-review.googlesource.com/1155069 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#207} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/media/blink/video_frame_compositor.cc [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/media/blink/video_frame_compositor.h [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/media/blink/video_frame_compositor_unittest.cc [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/media/blink/webmediaplayer_impl_unittest.cc [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/third_party/blink/public/platform/web_video_frame_submitter.h [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.cc [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.h [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/third_party/blink/renderer/platform/graphics/video_frame_submitter.h [modify] https://crrev.com/2659be0878db2b3299ee9912757a6b438184f85d/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
,
Jul 30
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Jul 13