New issue
Advanced search Search tips

Issue 863199 link

Starred by 1 user
Status: Fixed
Owner:
pwang@chromium.org
Closed: Jul 19
Cc:
ihf@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Write a test to check that FB options are disabled in the kernel

Project Member Reported by marc...@chromium.org, Jul 12 
For context, see:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1135724

It seems that we keep reenabling FB_* modules, which uses memory and can potentially expose and API which we don't support.

There is an existing kernel test (kernel_ConfigVerify.py) and we could model something after it ("graphics_KernelConfig") which checks that the FB_* options are not enabled by mistake.

Comment 1 by marc...@chromium.org, Jul 18

Cc: -pwang@chromium.org
Owner: pwang@chromium.org
Status: Assigned (was: Untriaged)
Po-Hsien, do you have time to look into it?

Comment 2 by marc...@chromium.org, Jul 18 

(for context, it seems as if FB is also partially enabled on AMD boards... at least judging by https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1136344)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8f88f01b216cbbc17f629bb49e054716030818ea

commit 8f88f01b216cbbc17f629bb49e054716030818ea
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Wed Jul 18 01:47:39 2018

graphics_KernelConfig: new test for graphics kernel flag

New test for graphics related kernel flag.

BUG= chromium:863199 
TEST=test_that kevin graphics_KernelConfig (Expected failure since
CL:863173)

Change-Id: I42472ba07f2a614c95f0fe03362f0218f2ca046b
Reviewed-on: https://chromium-review.googlesource.com/1141331
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Commit-Queue: Pohsien Wang <pwang@chromium.org>
Tested-by: Pohsien Wang <pwang@chromium.org>

[add] https://crrev.com/8f88f01b216cbbc17f629bb49e054716030818ea/client/site_tests/graphics_KernelConfig/control
[add] https://crrev.com/8f88f01b216cbbc17f629bb49e054716030818ea/client/site_tests/graphics_KernelConfig/graphics_KernelConfig.py
[modify] https://crrev.com/8f88f01b216cbbc17f629bb49e054716030818ea/tko/perf_upload/perf_dashboard_config.json
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/98bbcd4e8c631b0e0fb6ab3197e1c4598a12b4d4

commit 98bbcd4e8c631b0e0fb6ab3197e1c4598a12b4d4
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Wed Jul 18 08:40:09 2018

autotest-tests-graphics: add graphics_KernelConfig

Add deps for graphics_KernelConfig.

BUG= chromium:863199 
TEST=build autotest-tests-graphics and check.
CQ-DEPEND=CL:1141331

Change-Id: I32e5d1b90b4d01ae8f00ccd2e3f97e12e8373c60
Reviewed-on: https://chromium-review.googlesource.com/1141348
Commit-Ready: Pohsien Wang <pwang@chromium.org>
Tested-by: Pohsien Wang <pwang@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/98bbcd4e8c631b0e0fb6ab3197e1c4598a12b4d4/chromeos-base/autotest-tests-graphics/autotest-tests-graphics-9999.ebuild
►

Sign in to add a comment