New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863185 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Result deletion does not seem to be working

Project Member Reported by haddowk@chromium.org, Jul 12

Issue description


Results should be removed from the device after a certain time after offload, it seems the results are not being removed.

Expected - results should be removed after 3 days.
 
Cc: mattmallett@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3bc3be032e5005fe7a9206f24c29696a83811495

commit 3bc3be032e5005fe7a9206f24c29696a83811495
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Jul 16 23:31:59 2018

[autotest] Fix issue where offloaded jobs are never pruned.

Jobs are open until they are pruned, not necessarily just uploaded
change the code to reflect this.

When checking a directory exists an OSError can be thrown, handle
that as if the directory does not exist.

TEST=tryjob
BUG= chromium:863470 , chromium:863185 

Change-Id: I58127c521dbd666551465e117b44f78b6730a173
Reviewed-on: https://chromium-review.googlesource.com/1136793
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/3bc3be032e5005fe7a9206f24c29696a83811495/site_utils/job_directories.py
[modify] https://crrev.com/3bc3be032e5005fe7a9206f24c29696a83811495/site_utils/gs_offloader.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 16

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c5625e52d4682ca7e2366f1dce895429f7a38475

commit c5625e52d4682ca7e2366f1dce895429f7a38475
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Jul 16 23:41:23 2018

[autotest] Fix issue where offloaded jobs are never pruned.

Jobs are open until they are pruned, not necessarily just uploaded
change the code to reflect this.

When checking a directory exists an OSError can be thrown, handle
that as if the directory does not exist.

TEST=tryjob
BUG= chromium:863470 , chromium:863185 

Change-Id: I58127c521dbd666551465e117b44f78b6730a173
Reviewed-on: https://chromium-review.googlesource.com/1136793
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 3bc3be032e5005fe7a9206f24c29696a83811495)
Reviewed-on: https://chromium-review.googlesource.com/1139113
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/c5625e52d4682ca7e2366f1dce895429f7a38475/site_utils/job_directories.py
[modify] https://crrev.com/c5625e52d4682ca7e2366f1dce895429f7a38475/site_utils/gs_offloader.py

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 16

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cb0298cb76c8dae7609f7b512bc7fa451890da08

commit cb0298cb76c8dae7609f7b512bc7fa451890da08
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Jul 16 23:44:06 2018

[autotest] Fix issue where offloaded jobs are never pruned.

Jobs are open until they are pruned, not necessarily just uploaded
change the code to reflect this.

When checking a directory exists an OSError can be thrown, handle
that as if the directory does not exist.

TEST=tryjob
BUG= chromium:863470 , chromium:863185 

Change-Id: I58127c521dbd666551465e117b44f78b6730a173
Reviewed-on: https://chromium-review.googlesource.com/1136793
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 3bc3be032e5005fe7a9206f24c29696a83811495)
Reviewed-on: https://chromium-review.googlesource.com/1139114
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/cb0298cb76c8dae7609f7b512bc7fa451890da08/site_utils/job_directories.py
[modify] https://crrev.com/cb0298cb76c8dae7609f7b512bc7fa451890da08/site_utils/gs_offloader.py

Sign in to add a comment