New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

crosskylabadmin: Repair task timeout is too short

Project Member Reported by pprabhu@chromium.org, Jul 12

Issue description

We're currently setting the admin task timeout to 20 minutes.
This isn't enough on some cases.
e.g.: https://chrome-swarming.appspot.com/task?id=3ea8f55168c9b711&refresh=10&request_detail=true&show_raw=1


 
> We're currently setting the admin task timeout to 20 minutes.
> This isn't enough on some cases.

To be clear:  This isn't enough in almost any case other than "the
DUT didn't really need repair in the first case".

In practical cases that I've seen, the work to successfully re-install
from USB runs at least 40 minutes end-to-end; longer times are possible,
and shouldn't be considered out of the ordinary.

So, I'd recommend at least 90 minutes for a repair timeout.  To be safe,
2 hours would be better.

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/infra/infra/+/1135826

I'm starting with 90 minutes.
If we notice timeouts, we can bump it further / split timeouts based on the task being created.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0f97fffdaafffc2fe43f770d199f0561a8cfab64

commit 0f97fffdaafffc2fe43f770d199f0561a8cfab64
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Jul 12 23:51:12 2018

crosskylabadmin: Bump up execution timeout for admin tasks

BUG= chromium:863180 

Change-Id: I29d2974a2f743c5a593dc7daace78d3b15bc629f
Reviewed-on: https://chromium-review.googlesource.com/1135826
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/0f97fffdaafffc2fe43f770d199f0561a8cfab64/go/src/infra/appengine/crosskylabadmin/app/frontend/frontend.go
[modify] https://crrev.com/0f97fffdaafffc2fe43f770d199f0561a8cfab64/go/src/infra/appengine/crosskylabadmin/app/clients/swarming.go

Status: Fixed (was: Started)

Sign in to add a comment