New issue
Advanced search Search tips

Issue 863178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

SMB share discovery and mounting exhibit a race condition

Project Member Reported by baileyberro@chromium.org, Jul 12

Issue description

There is a race condition when opening the Add Share dialog between when results from discovering shares on the network return and a user clicking the "Mount" button. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4121d448f2e31f0d2a00c2e4cc8d045942a862d1

commit 4121d448f2e31f0d2a00c2e4cc8d045942a862d1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 16 23:25:51 2018

Remove race condition in Smb Share discovery

Stores a mount call if host discovery is not yet complete and runs it as
soon as the first share names start coming back, indicating that host
discovery is complete.

The mount can be attempted before share discovery is complete because
mounting via a hostname is only dependent on host discovery for name
resolution.

Bug:  757625 ,  863178 
Change-Id: If53ec9061c79a4f408278be4ddd990a7c9ca3791
Reviewed-on: https://chromium-review.googlesource.com/1136528
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575477}
[modify] https://crrev.com/4121d448f2e31f0d2a00c2e4cc8d045942a862d1/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
[modify] https://crrev.com/4121d448f2e31f0d2a00c2e4cc8d045942a862d1/chrome/browser/ui/webui/settings/chromeos/smb_handler.h

Labels: smb-native
Status: Fixed (was: Assigned)

Sign in to add a comment