New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863174 link

Starred by 2 users
Status: Assigned
Owner:
ma...@chromium.org
Cc:
yyushkina@chromium.org
kmilka@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 857256



Sign in to add a comment

[New Tab] Develop a render browser test framework for the new tab page

Project Member Reported by ma...@chromium.org, Jul 12 
So that regressions can be avoided, we should have a framework that deterministically produces captures of the NTP for comparison.

Desktop only, because Android already has this.

Comment 1 by ramyan@chromium.org, Jul 12

Blocking: 857256
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/838e1e5993152298e2af3fb7ef16d8dbc8dee9dd

commit 838e1e5993152298e2af3fb7ef16d8dbc8dee9dd
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Jul 13 13:25:58 2018

[New Tab] Create a render browsertest for the local NTP

Currently in its own target, and simply dumps the output to a file without
checking

Bug: 863174
Test: out/Default/ntp_render_browsertests
Change-Id: I61ca7714005c3b1d40f354d9f2ca519750843108
Reviewed-on: https://chromium-review.googlesource.com/1135756
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574897}
[add] https://crrev.com/838e1e5993152298e2af3fb7ef16d8dbc8dee9dd/chrome/browser/ui/search/local_ntp_render_browsertest.cc
[modify] https://crrev.com/838e1e5993152298e2af3fb7ef16d8dbc8dee9dd/chrome/browser/ui/search/local_ntp_test_utils.cc
[modify] https://crrev.com/838e1e5993152298e2af3fb7ef16d8dbc8dee9dd/chrome/browser/ui/search/local_ntp_test_utils.h
[modify] https://crrev.com/838e1e5993152298e2af3fb7ef16d8dbc8dee9dd/chrome/test/BUILD.gn
[add] https://crrev.com/838e1e5993152298e2af3fb7ef16d8dbc8dee9dd/components/test/data/ntp/render/1200x800_DefaultMV.png

Comment 3 by twelling...@chromium.org, Jul 17

Labels: zine-triaged
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8844385a0694085493f7808e77e50912d5f60b4

commit d8844385a0694085493f7808e77e50912d5f60b4
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Aug 01 19:03:35 2018

[New Tab Page] Add a custom links test case to the render framework.

Bug: 863174
Change-Id: I4d694bc9d8faedb7d74a5aedb0d6bf7caffc8d0a
Reviewed-on: https://chromium-review.googlesource.com/1157662
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579882}
[modify] https://crrev.com/d8844385a0694085493f7808e77e50912d5f60b4/chrome/browser/ui/search/local_ntp_render_browsertest.cc
[modify] https://crrev.com/d8844385a0694085493f7808e77e50912d5f60b4/components/test/data/ntp/render/1200x800_DefaultMV.png
[add] https://crrev.com/d8844385a0694085493f7808e77e50912d5f60b4/components/test/data/ntp/render/1200x800_MVWithCustomLinks.png

Comment 5 by yyushkina@chromium.org, Aug 2

Labels: Target-70

Comment 6 by yyushkina@chromium.org, Aug 2

Cc: yyushkina@chromium.org ramyan@chromium.org

Comment 7 by ramyan@chromium.org, Aug 22

Cc: kmilka@chromium.org
►

Sign in to add a comment