New issue
Advanced search Search tips

Issue 863172 link

Starred by 2 users
Status: Fixed
Owner:
jopra@chromium.org
Closed: Jul 16
Cc:
smbar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros-adapta: text invisible in window decorations

Project Member Reported by smbar...@chromium.org, Jul 12 
Text in GTK3 client-side decorations is invisible with cros-adapta. Sometimes this is just the title of the app, but it can also have important information like time elapsed and moves left in gnome-mahjongg.

repro: I used gnome-tweak-tool to force the dark mode change, and to switch to Greybird as the theme. cros-adapta light and dark variants both hide the titlebar text.
crosadapta_light.png
3.0 MB View Download
crosadapta_dark.png
3.0 MB View Download
greybird.png
3.0 MB View Download

Comment 1 by jopra@chromium.org, Jul 13

Status: Started (was: Untriaged)
Thanks smbarber, I'm currently working on resolving a similar issue.
My CL for that issue should re-enable the time and moves left label.

The 'difficulty' text is actually the title of the window and so is being hidden to match Chrome OS native windows.

We could potentially turn titles on or off in only a subset of apps if necessary.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cros-adapta/+/091912dc735aa2a52e0c1badb9a3b9f25531b463

commit 091912dc735aa2a52e0c1badb9a3b9f25531b463
Author: Josh Pratt <jopra@chromium.org>
Date: Fri Jul 13 12:09:36 2018

Reset label hiding in the titlebar if the label is a button label.

Fixes titlebar button bar where button labels were unintentially made
transparent by the rule that hides the titlebar title.

Button labels should now keep their button's color value.

Bug:  863172 
Change-Id: I9fceb4f2be0be5ddec005c2a7cd80457b76e2493
Reviewed-on: https://chromium-review.googlesource.com/1127910
Commit-Ready: Josh Pratt <jopra@chromium.org>
Tested-by: Josh Pratt <jopra@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>

[modify] https://crrev.com/091912dc735aa2a52e0c1badb9a3b9f25531b463/gtk-3.0/window.css
►

Sign in to add a comment