New issue
Advanced search Search tips

Issue 863170 link

Starred by 1 user
Status: Fixed
Owner:
corising@chromium.org
Closed: Sep 28
Cc:
pbos@chromium.org
rdevlin....@chromium.org
jawag@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add anchor effect to extension-ntp-warning

Project Member Reported by pbos@chromium.org, Jul 12 
If we do go with something more generic for solving the bubble-anchor effect this should be a good dialog to just try it out with.

This specific dialog is NtpOverriddenBubbleDelegate, but I assume we'd at least fix a wider class of problem (all ExtensionMessageBubbleController::Delegate dialogs).
no-anchor-ntp.png
45.9 KB View Download

Comment 1 by jawag@chromium.org, Jul 12

Cc: jawag@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e767f87e7a62609817cff5bce1de36a4d60dfbd5

commit e767f87e7a62609817cff5bce1de36a4d60dfbd5
Author: Caroline Rising <corising@chromium.org>
Date: Tue Sep 18 19:04:47 2018

Add inkdrop highlighting to buttons with anchored widgets.

Add method to make buttons observers of any widgets that are anchored to them. Change inkdrop highlight for buttons when anchored widgets are shown or removed. Fix cases where a widget is anchored to the location bar but a different view should be highlighted. Change highlighting to SetBackground when used for extension actions in BrowserActionsContainer to protect inkdrop highlight state during layout calls.

Bug:  863170 ,  824536 
Change-Id: Id6abdfa7a70955b3cb1873b6c8013f0496455f68
Reviewed-on: https://chromium-review.googlesource.com/1165601
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592131}
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ash/shelf/overflow_button.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/cocoa/translate/translate_bubble_bridge_views.mm
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bubble_anchor_util_views.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/bubble_anchor_util_views.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/page_action/page_action_icon_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/page_action/page_action_icon_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/passwords/password_bubble_view_base.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/bubble/bubble_dialog_delegate_view.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/bubble/bubble_dialog_delegate_view.h
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/bubble/bubble_dialog_delegate_view_unittest.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/controls/button/button.cc
[modify] https://crrev.com/e767f87e7a62609817cff5bce1de36a4d60dfbd5/ui/views/controls/button/button.h

Comment 3 by corising@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment