"LifecycleTest.Exe_TerminateProcess" is flaky |
||||||||||||||
Issue description"LifecycleTest.Exe_TerminateProcess" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJMaWZlY3ljbGVUZXN0LkV4ZV9UZXJtaW5hdGVQcm9jZXNzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jul 12
Nico, the first failure occurs with https://chromium-review.googlesource.com/c/chromium/src/+/1134531/2. The failures are timeout failures, so maybe there is a relation. Do you know?
,
Jul 12
It's a good thought, but that CL only touches Android bots while all the failures are on a Fuchsia bot, not on an Android bot. So that can't be it.
,
Jul 12
Ah, yeah, and I see the flakes have been occurring for much longer.
,
Jul 12
Adding the ServiceManager component to help find an appropriate owner. Ken, do you know who this can be directed towards? I don't really want to disable the entire test, given that it's infrequently flaky and only on fuschia.
,
Jul 13
Thanks. Fuchsia-only, sounds like a job for the +wez@!
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06d889335c8b16920aa0ee8f210712a15f9b5d58 commit 06d889335c8b16920aa0ee8f210712a15f9b5d58 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri Jul 13 16:35:21 2018 Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia TBR: jam@chromium.org Bug: 863166 Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa Reviewed-on: https://chromium-review.googlesource.com/1136029 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574942} [modify] https://crrev.com/06d889335c8b16920aa0ee8f210712a15f9b5d58/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
,
Jul 13
Temporarily disabled just on Fuchsia in the meantime. Until yesterday I had no idea I was spelling fuchsia wrong. I found it very curious that I couldn't find any "fuschia" references in the code base...
,
Jul 13
,
Jul 13
Thanks Ken. ;) If it's Fuchsia-specific then it is most likely some subtle race-condition, so the test should really be disabled everywhere, not just on Fuchsia. However, I'll try to repro this locally to see if we can get any further idea what's going on.
,
Jul 13
BTW if you really think it's not Fuchsia-specific, feel free to punt it back to me and I can take a look.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a45ad357bacc79ea4acd851ec2f40c9de666d464 commit a45ad357bacc79ea4acd851ec2f40c9de666d464 Author: Wez <wez@chromium.org> Date: Fri Jul 13 20:08:47 2018 Clean up LifecycleTest to use QuitClosure and BarrierClosure. Bug: 863166 Change-Id: I024feeb9c3e687632841da11e44222dc1b1f8acb Reviewed-on: https://chromium-review.googlesource.com/1136722 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575041} [modify] https://crrev.com/a45ad357bacc79ea4acd851ec2f40c9de666d464/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
,
Jul 13
Looks like we have seen other LifecycleTest.* tests fail on FYI, e.g: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20%28dbg%29/22122
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c5ca1ecf51d5511b1ba4abcd5f67801f0054d38 commit 3c5ca1ecf51d5511b1ba4abcd5f67801f0054d38 Author: Wez <wez@chromium.org> Date: Tue Jul 17 19:02:09 2018 Revert "Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia" This reverts commit 06d889335c8b16920aa0ee8f210712a15f9b5d58. Reason for revert: Flaking test has been refactored in such a way that we believe it will no longer flake. (Sheriffs: Please re-land the CL below if the test starts to flake again!) Original change's description: > Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia > > TBR: jam@chromium.org > Bug: 863166 > Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa > Reviewed-on: https://chromium-review.googlesource.com/1136029 > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574942} TBR=kpaulhamus@chromium.org, rockot@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863166 Change-Id: I7a816e991cccb0559dcf8e0a43c96920a933352b Reviewed-on: https://chromium-review.googlesource.com/1140873 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575742} [modify] https://crrev.com/3c5ca1ecf51d5511b1ba4abcd5f67801f0054d38/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
,
Jul 17
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22416b58bf581f5c7797b6697087e7cff32c891a commit 22416b58bf581f5c7797b6697087e7cff32c891a Author: Wez <wez@chromium.org> Date: Tue Jul 17 19:09:49 2018 Remove errant logging line added while debugging. TBR=rockot Bug: 863166 Change-Id: I518cd477f1a4fbcd501d419479dd58c4e53be9ae Reviewed-on: https://chromium-review.googlesource.com/1140787 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575745} [modify] https://crrev.com/22416b58bf581f5c7797b6697087e7cff32c891a/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
,
Jul 26
Flaked again in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-rel/869 -> re-disabling. Marking this blocked-on getting thread stacks when test sub-processes hang.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/640727c258e3edfd3089e3ea696f9c4e2294bdfe commit 640727c258e3edfd3089e3ea696f9c4e2294bdfe Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Thu Jul 26 14:14:32 2018 Reland "Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia" This is a reland of 06d889335c8b16920aa0ee8f210712a15f9b5d58 Original change's description: > Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia > > TBR: jam@chromium.org > Bug: 863166 > Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa > Reviewed-on: https://chromium-review.googlesource.com/1136029 > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574942} TBR: jam Bug: 863166 Change-Id: Ie5c02a954b9d51f6ec24c99de38af8f2a0216dfa Reviewed-on: https://chromium-review.googlesource.com/1151310 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#578289} [modify] https://crrev.com/640727c258e3edfd3089e3ea696f9c4e2294bdfe/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
,
Jul 27
,
Sep 11
,
Sep 11
,
Oct 17
,
Jan 19
(4 days ago)
This test no longer exists. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by kpaulhamus@chromium.org
, Jul 12