New issue
Advanced search Search tips

Issue 863164 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 863425



Sign in to add a comment

Wcast-qual-unrelated on at leas the mac clang tot bots

Project Member Reported by thakis@chromium.org, Jul 12

Issue description

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTMac%2F1852%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout


FAILED: obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/screen_capturer_mac.o 
export DEVELOPER_DIR=/b/c/b/ToTMac/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/screen_capturer_mac.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"336750\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCOMPONENT_BUILD -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_ENABLE_PROTOBUF=1 -DHAVE_SCTP -DENABLE_EXTERNAL_AUTH -DUSE_BUILTIN_SW_CODECS -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -I../.. -Igen -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/libyuv/include -I../../third_party/webrtc/sdk/objc/Framework/Classes -I../../third_party/webrtc/sdk/objc/Framework/Classes/Audio -I../../third_party/webrtc/sdk/objc/Framework/Classes/Common -I../../third_party/webrtc/sdk/objc/Framework/Classes/Metal -I../../third_party/webrtc/sdk/objc/Framework/Classes/PeerConnection -I../../third_party/webrtc/sdk/objc/Framework/Classes/UI -I../../third_party/webrtc/sdk/objc/Framework/Classes/Video -I../../third_party/webrtc/sdk/objc/Framework/Classes/VideoToolbox -I../../third_party/webrtc/sdk/objc/Framework/Headers -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-address-of-packed-member -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O2 -fno-omit-frame-pointer -g1 -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem ../../third_party/abseil-cpp -Wstrict-overflow -Wmissing-field-initializers -std=c++14 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -fobjc-arc -c ../../third_party/webrtc/modules/desktop_capture/mac/screen_capturer_mac.mm -o obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/screen_capturer_mac.o
../../third_party/webrtc/modules/desktop_capture/mac/screen_capturer_mac.mm:171:30: error: ISO C++ does not allow reinterpret_cast from 'CGWindowID (*)[1]' to 'const void **' because it casts away qualifiers, even though the source and destination types are unrelated [-Werror,-Wcast-qual-unrelated]
      CFArrayCreate(nullptr, reinterpret_cast<const void**>(&ids), 1, nullptr);
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[11942/53076] OBJCXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/screen_capturer_darwin.o
[11943/53076] OBJCXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/desktop_configuration.o
[11944/53076] OBJCXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/window_finder_mac.o
[11945/53076] CXX obj/third_party/webrtc/modules/desktop_capture/primitives/desktop_region.o
[11946/53076] CXX obj/third_party/webrtc/modules/congestion_controller/rtp/congestion_controller/send_side_congestion_controller.o
[11947/53076] CXX obj/third_party/webrtc/modules/pacing/pacing/packet_queue_interface.o
[11948/53076] CXX obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator/inter_arrival.o
[11949/53076] CXX obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator/overuse_detector.o
[11950/53076] OBJCXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/mouse_cursor_monitor_mac.o
[11951/53076] CXX obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator/aimd_rate_control.o
[11952/53076] CXX obj/third_party/webrtc/modules/pacing/pacing/packet_queue.o
[11953/53076] OBJCXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/window_capturer_mac.o
FAILED: obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/window_capturer_mac.o 
export DEVELOPER_DIR=/b/c/b/ToTMac/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/window_capturer_mac.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"336750\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCOMPONENT_BUILD -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_ENABLE_PROTOBUF=1 -DHAVE_SCTP -DENABLE_EXTERNAL_AUTH -DUSE_BUILTIN_SW_CODECS -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -I../.. -Igen -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/libyuv/include -I../../third_party/webrtc/sdk/objc/Framework/Classes -I../../third_party/webrtc/sdk/objc/Framework/Classes/Audio -I../../third_party/webrtc/sdk/objc/Framework/Classes/Common -I../../third_party/webrtc/sdk/objc/Framework/Classes/Metal -I../../third_party/webrtc/sdk/objc/Framework/Classes/PeerConnection -I../../third_party/webrtc/sdk/objc/Framework/Classes/UI -I../../third_party/webrtc/sdk/objc/Framework/Classes/Video -I../../third_party/webrtc/sdk/objc/Framework/Classes/VideoToolbox -I../../third_party/webrtc/sdk/objc/Framework/Headers -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-address-of-packed-member -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O2 -fno-omit-frame-pointer -g1 -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem ../../third_party/abseil-cpp -Wstrict-overflow -Wmissing-field-initializers -std=c++14 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -fobjc-arc -c ../../third_party/webrtc/modules/desktop_capture/window_capturer_mac.mm -o obj/third_party/webrtc/modules/desktop_capture/desktop_capture_objc/window_capturer_mac.o
../../third_party/webrtc/modules/desktop_capture/window_capturer_mac.mm:110:30: error: ISO C++ does not allow reinterpret_cast from 'CGWindowID (*)[1]' to 'const void **' because it casts away qualifiers, even though the source and destination types are unrelated [-Werror,-Wcast-qual-unrelated]
      CFArrayCreate(nullptr, reinterpret_cast<const void**>(&ids), 1, nullptr);
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.



This is from r336738 I'd guess.


Since the warning is in webrtc, the fix will take a while to make it in, so we should probably disable in the meantime. Looks like the non-mac bots are happy, so probably should just disable on mac.
 
Status: Assigned (was: Untriaged)
mac triage: assigned :)
Blocking: 863425
Status: WontFix (was: Assigned)
It went away again in https://ci.chromium.org/buildbot/chromium.clang/ToTMac/1925 somehow. Improved in 337419:337426 -- aha, probably r337422.

Sign in to add a comment