New issue
Advanced search Search tips

Issue 863162 link

Starred by 1 user
Status: Fixed
Owner:
tbarzic@chromium.org
Closed: Aug 10
Cc:
agawronska@chromium.org
ovanieva@chromium.org
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 812039



Sign in to add a comment

[Demo mode]: In demo sessions, Chrome should attempt to install Chrome apps/extensions from the offline demo mode resources

Project Member Reported by tbarzic@chromium.org, Jul 12 
Offline demo mode resources (imageloader image stored on the stateful partition that contains demo resources that should be available to offline demo sessions) will contain Chrome apps in addition to Android apps.

When demo session starts, Chrome should attempt to install and load extensions/Chrome apps from the mounted demo resources image, to make those apps available regardless of the network state.
Note that the extensions installed from the demo mode resources image should be updateable if the device goes online, and find updates in the web store.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f09c410c53b4d4da4f49406110603088d03893ed

commit f09c410c53b4d4da4f49406110603088d03893ed
Author: Toni Barzic <tbarzic@chromium.org>
Date: Fri Jul 20 19:45:52 2018

Support setting mount points in fake image loader client

Adds logic to register and load/unload components to fake image loader
client, so it can be used to test code that depends on image loader
client.

Introduces SetMountPathForComponent that sets up mount points
LoadComponent/LoadComponentAtPath return as component's mount point when
called (if a mount point has not been set, the LoadComponent methods
will fail).

Implements logic to register/remove components - it keeps mapping from a
registered component name to its version in memory.

BUG= 863162 

Change-Id: Iffa3504fc92d495cc46a35caffd3acdd4b7038c8
Reviewed-on: https://chromium-review.googlesource.com/1145463
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576956}
[modify] https://crrev.com/f09c410c53b4d4da4f49406110603088d03893ed/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/f09c410c53b4d4da4f49406110603088d03893ed/chromeos/dbus/fake_image_loader_client.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dff5156949c56367eb3b8305d41051597d8bcf66

commit dff5156949c56367eb3b8305d41051597d8bcf66
Author: Toni Barzic <tbarzic@chromium.org>
Date: Tue Jul 24 19:55:46 2018

Add external extensions loader for pre-installed demo session apps

External loader that loads extension CRXs from the offline demo
resources image mounted by the image loader service.

It expects that offline demo resources, in addition to actual CRX files
to install, a JSON that maps bundled app IDs to the CRX location and
app version (in the same format as for other external extensions, e.g.
default Chrome OS apps).

Bug:  863162 

Change-Id: I88aa544be10d74c1ead10a685bb7fd238f18cdd0
Reviewed-on: https://chromium-review.googlesource.com/1134579
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577648}
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[add] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader.cc
[add] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader.h
[add] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader_unittest.cc
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/demo_mode/demo_session.cc
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/demo_mode/demo_session.h
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/demo_mode/demo_session_unittest.cc
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/dff5156949c56367eb3b8305d41051597d8bcf66/chrome/browser/extensions/external_provider_impl.cc

Comment 3 by michae...@chromium.org, Aug 3

Blocking: 812039
Labels: -Type-Bug Type-Feature

Comment 4 by tbarzic@chromium.org, Aug 10

Status: Fixed (was: Started)
►

Sign in to add a comment