ipc owners check false positive in blink |
||
Issue descriptionhttps://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8941180706128355424/+/steps/presubmit/0/stdout ** Presubmit ERRORS ** Found OWNERS files that need to be updated for IPC security review coverage. Please update the OWNERS files below: *************** Because of the presence of files: third_party/blink/renderer/platform/bindings/exception_messages.cc third_party/blink/renderer/platform/bindings/exception_messages.h third_party/blink/renderer/platform/bindings/OWNERS needs the following 4 lines added: per-file *_messages.cc=set noparent per-file *_messages.cc=file://ipc/SECURITY_OWNERS per-file *_messages*.h=set noparent per-file *_messages*.h=file://ipc/SECURITY_OWNERS *************** Presubmit checks took 12.0s to calculate. That file is not an IPC message file.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe635eb8bad48721ea1520ca3efc46b1b173d7e commit ebe635eb8bad48721ea1520ca3efc46b1b173d7e Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Jul 13 12:36:06 2018 Skip IPC owner checks for //third_party/blink/renderer/platform/bindings exception_messages.* triggers the pattern match for the IPC owner presubmit, but it isn't actually an IPC-related file. Bug: 863161 Change-Id: Ia5655c49c991bcab308dca36bd41c4afc574f941 Reviewed-on: https://chromium-review.googlesource.com/1136063 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574887} [modify] https://crrev.com/ebe635eb8bad48721ea1520ca3efc46b1b173d7e/PRESUBMIT.py
,
Jul 13
|
||
►
Sign in to add a comment |
||
Comment 1 by e...@chromium.org
, Jul 13