Error Console NOT Enabled |
|||||||
Issue descriptionChrome Version: 68.0.3440.59 What steps will reproduce the problem? 1. Load extension with error 2. Click errors to open error console What is the expected result? Error console shows errors What happens instead of that? Errors not shown in error console
,
Jul 12
@James, Devlin: Any thoughts on this? Should we come up with a fix and merge to M68, or at this point better to wait for 69? Markning this as Available, since @hcarmona was able to reproduce.
,
Jul 12
Hmm... with where we are in the release cycle, I don't see a strong reason to push for a merge to 68. I'm fine fixing for 69 and launching then.
,
Jul 12
,
Jul 12
,
Jul 13
,
Jul 18
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e3ae8fcb55c804981fd83075cffda76f3d57339 commit 3e3ae8fcb55c804981fd83075cffda76f3d57339 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Jul 19 03:45:11 2018 Extensions: make error console enabled if profile is in dev mode Bug: 863145 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia8b82930d525b9ba3eee1e3332da1d5e35809131 Reviewed-on: https://chromium-review.googlesource.com/1141220 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576356} [modify] https://crrev.com/3e3ae8fcb55c804981fd83075cffda76f3d57339/chrome/browser/extensions/error_console/error_console.cc [modify] https://crrev.com/3e3ae8fcb55c804981fd83075cffda76f3d57339/chrome/browser/extensions/error_console/error_console_unittest.cc [modify] https://crrev.com/3e3ae8fcb55c804981fd83075cffda76f3d57339/chrome/browser/resources/md_extensions/error_page.js [modify] https://crrev.com/3e3ae8fcb55c804981fd83075cffda76f3d57339/chrome/browser/resources/md_extensions/manager.html
,
Jul 19
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hcarmona@chromium.org
, Jul 12