New issue
Advanced search Search tips

Issue 863145 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Error Console NOT Enabled

Project Member Reported by hcarmona@chromium.org, Jul 12

Issue description

Chrome Version: 68.0.3440.59

What steps will reproduce the problem?
1. Load extension with error
2. Click errors to open error console

What is the expected result?
Error console shows errors

What happens instead of that?
Errors not shown in error console
 
expected.png
47.1 KB View Download
actual.png
108 KB View Download
From chat w/ Devlin:

https://cs.chromium.org/chromium/src/chrome/browser/extensions/error_console/error_console.cc?q=error_console.cc&sq=package:chromium&g=0&l=177-187

it only respects the FeatureSwitch value if it has an override

so by default, we'll only look at which channel - and it's restricted to dev

we should just clean that whole method up to return the value of profile_->GetPrefs()->GetBoolean(prefs::kExtensionsUIDeveloperMode))
Cc: jawag@chromium.org
Status: Available (was: Unconfirmed)
@James, Devlin: Any thoughts on this? Should we come up with a fix and merge to M68, or at this point better to wait for 69?

Markning this as Available, since @hcarmona was able to reproduce.
Hmm... with where we are in the release cycle, I don't see a strong reason to push for a merge to 68.  I'm fine fixing for 69 and launching then.
Labels: -M-68 M-69
Cc: aee@chromium.org
Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19

Status: Fixed (was: Started)

Sign in to add a comment