New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863122 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ youcheng@chromium.org
█ mka@chromium.org
█ rrangel@chromium.org
gmeinke@chromium.org
vapier@chromium.org
pmalani@chromium.org
cmt...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros debug: update for newer gdb logic

Project Member Reported by norvez@chromium.org, Jul 12 

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8941335085363028032


VMTest (attempt 1) fails with:

"
23:04:27: INFO: Running VM test cros_vm_test.
23:04:28: INFO: Setting up the VM for testing.
23:04:28: INFO: RunCommand: parted -m /b/swarming/w/ir/cache/cbuild/repository/src/build/images/betty/latest-cbuildbot/chromiumos_qemu_image.bin unit MB print
23:05:14: INFO: VM started at port 60518
23:05:14: INFO: The VM has been successfully set up. Ready to run tests.
23:05:14: INFO: Running test for cros shell.
23:05:14: INFO: Test to use shell command to write a file to the VM device.
23:05:14: INFO: RunCommand: cros shell --no-known-hosts ssh://localhost:60518 -- 'echo "shell command test file" > /tmp/shell-test'
23:05:15: INFO: Test to use shell command to read a file on the VM device.
23:05:15: INFO: RunCommand: cros shell --no-known-hosts ssh://localhost:60518 -- 'cat /tmp/shell-test'
23:05:17: INFO: Test to use shell command to remove a file on the VM device.
23:05:17: INFO: RunCommand: cros shell --no-known-hosts ssh://localhost:60518 -- 'rm /tmp/shell-test'
23:05:18: INFO: Test for cros shell passed.
23:05:18: INFO: Running test for cros debug.
23:05:18: INFO: Test to start and debug a new process on the VM device.
23:05:18: INFO: RunCommand: cros debug --exe /bin/bash ssh://localhost:60518
23:05:22: ERROR: Failed to start and debug a new process on the VM device.
23:05:22: INFO: 
"

Assigning to sheriffs for triage.

Note: because of  crbug.com/863120  the build report is misleading, VMTest (attempt 1) is the one failing.

Comment 1 by mka@chromium.org, Jul 12

Cc: cmt...@chromium.org vapier@chromium.org
A bit more context:

----------- Start of cros debug log -----------
23:05:22: ERROR: cros debug failed before completing.
23:05:22: ERROR: return code: None; command: gdb_remote --ssh --board betty --remote localhost --ssh_port 60518 --remote_file /bin/bash
[Errno 2] No such file or directory
-----------  End of cros debug log  -----------

And then we have:

http://crrev.com/c/1121139 ("cros-devutils: drop gdb_remote/gdb_x86_local"), which just landed a few days ago.

According to  Bug 361767  gdb-${BOARD} should be used instead of gdb_remote

Comment 2 by vapier@chromium.org, Jul 12 

gdb_remote has been an `exit 0` nop since Oct 2017, so any tests relying on it haven't actually been validating anything.  we should disable any related tests for now to unblock things.

Comment 3 by mka@chromium.org, Jul 12

Cc: mka@chromium.org
Owner: dgarr...@chromium.org
It doesn't seem to be any specific test, but chromite/cli/cros/cros_debug.py

Not sure who the owner would be, assigning to dgarrett@ since he poked around quite a bit in this repository. Please reassign if somebody else should be looking into this.

Comment 4 by dgarr...@chromium.org, Jul 12

Owner: gmeinke@chromium.org
Passing to the current bobby for riate.

Comment 5 by vapier@chromium.org, Jul 13 

i mean disable the test/code that is calling `cros debug` until we can fix cros debug

Comment 6 by gmeinke@chromium.org, Jul 13

Owner: mka@chromium.org
assigning to mka@ ... he has a fix in flight

Comment 7 by mka@chromium.org, Jul 13 

It's only a workaround that disables the test, we still need an owner for fixing the actual issue and re-enabling the test.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a45e2dc3dcb392175aa8ff31b368fd822da06129

commit a45e2dc3dcb392175aa8ff31b368fd822da06129
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Sat Jul 14 00:29:02 2018

command_vm_test: disable debug test

'cros debug' is currently broken since it still uses the gdb_remote,
which has was replaced by gdb-${BOARD} (chromium:361767).

BUG=chromium:863122
TEST=precq passes

Change-Id: I593d40614e72b59afdf46b52660d4fc6eca343ad
Reviewed-on: https://chromium-review.googlesource.com/1136661
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a45e2dc3dcb392175aa8ff31b368fd822da06129/cli/command_vm_test.py

Comment 9 by vapier@chromium.org, Jul 14

Components: Infra>Client>ChromeOS>Build
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Summary: cros debug: update for newer gdb logic (was: VM canary builders are failing)

Comment 10 by jettrink@chromium.org, Jul 16

Cc: rrangel@chromium.org pmalani@chromium.org
Copying current sheriffs

Comment 11 by jettrink@chromium.org, Jul 25

Cc: -jettrink@chromium.org
►

Sign in to add a comment