New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863120 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VMTest (attempt 1) fails but is marked as successful

Project Member Reported by norvez@chromium.org, Jul 12

Issue description

Looking at build:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8941335085363028032
https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8941335085363028032

The VMTest (attempt 1) step actually fails if you look at the log, but it's considered successful. Only (attempt 2), which fails for a different reason, is marked as failing. It sends people trying to diagnose issues on the wrong track.

Assigning to CI bobby for triage.
 
Owner: akes...@chromium.org
Testing failure, assigning to primary infra deputy 
Owner: gmeinke@chromium.org
This is not a hwtest lab issue. Looks to me like a logging issue in cbuildbot or legoland.

Both VMTest attempt 1 and 2 appears to me to have failed for the same reason, so I don't follow the premise of the bug. It is strange that it has a failure message in it and yet it is colored green though. https://logs.chromium.org/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8941335085363028032/+/steps/VMTest__attempt_1_/0/stdout

23:05:49: WARNING: Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 697, in Run
    self.PerformStage()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/vm_test_stages.py", line 278, in PerformStage
    self._RunTest(vm_test, per_test_results_dir)
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/vm_test_stages.py", line 225, in _RunTest
    RunCrosVMTest(self._current_board, self.GetImageDirSymlink())
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cbuildbot/stages/vm_test_stages.py", line 762, in RunCrosVMTest
    test.Run()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cli/command_vm_test.py", line 265, in Run
    self.RunTests()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cli/command_vm_test.py", line 257, in RunTests
    self.TestDebug()
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/cli/command_vm_test.py", line 60, in Wrapper
    raise TestError('Test for %s failed.' % command)
TestError: Test for cros debug failed.


I think the confusion is that the first attempt is marked as green despite failure. AFAIK that is the way it has always worked for retryable stages.

-> back to CI.
Cc: dgarr...@chromium.org
No, it shouldn't be green, it used to be orange. I just remembered that I'd already filed a similar issue on GoldenEye b/72806309
Cc: rrangel@chromium.org pmalani@chromium.org
Copying current sheriffs
Cc: -jettrink@chromium.org
Status: Fixed (was: Assigned)
Legoland is currently correctly rendering the failed VMTest 1 as a warning and is now rendered correctly in the UI. (Following the link shows the expected result.)

Sign in to add a comment