Reduce size of new tab button asset from 12 to 10 |
|||||
Issue descriptionWhat is the expected result? Each stroke of the NTB should be 2x10 (10x10 total) What happens instead? Each stroke is 2x12 (12x12 total) *No change to x or y positioning on the tabsrip *No change to hover/ripple sizes and/or positioning *For Refresh-non touch only
,
Jul 12
,
Jul 12
I went ahead and exported a new svg for the interim. I fully support programmatically drawing these, just didn't want that to block experimenting with a new size
,
Jul 12
Will take a look.
,
Jul 12
,
Jul 16
This is WontFix. Proportions of the overall Chrome feel better with the shorter tab heights. Leave the size as 12 for non-touch, 14 for touch.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bbdecbc729b5be5eefb7f14720a6159e1a9d513 commit 4bbdecbc729b5be5eefb7f14720a6159e1a9d513 Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Jul 18 14:23:57 2018 Manually paint the plus (+) icon with 2 dip strokes and round end-caps. TBR=estade@chromium.org Bug: 863117 Change-Id: Ie131dfdbc7620b8ce8f14948224089ac9ffa15bb Reviewed-on: https://chromium-review.googlesource.com/1138642 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#576040} [modify] https://crrev.com/4bbdecbc729b5be5eefb7f14720a6159e1a9d513/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/d70e7cb405c306a31770514289d1834e17dd153c/chrome/app/vector_icons/new_tab_button_plus.icon [modify] https://crrev.com/4bbdecbc729b5be5eefb7f14720a6159e1a9d513/chrome/browser/ui/views/tabs/new_tab_button.cc [modify] https://crrev.com/4bbdecbc729b5be5eefb7f14720a6159e1a9d513/chrome/browser/ui/views/tabs/new_tab_button.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pkasting@chromium.org
, Jul 12