Screen goes blank for a moment on entering tab grid from landscape |
||||||||
Issue descriptionApp Version: 69.0.3488.0 canary iOS Version: 10.3.3, 11.4.1 Device: iPhone URL: Steps to reproduce: 1. Launch Chrome app 2. Open a few tabs 3. Change to landscape mode 4. Tap on Tab switcher Observed results: Screen goes blank for a moment. Expected results: Screen should not go blank. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image: https://drive.google.com/file/d/1dGFtXbivbvdxPxYu6dxUK1g4gnU2BGhk/view
,
Jul 13
,
Jul 19
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/532527e25e9c040712d0623c308de2863e300204 commit 532527e25e9c040712d0623c308de2863e300204 Author: Mark Cogan <marq@google.com> Date: Fri Jul 20 12:24:04 2018 [iOS] Fix blank screen when entering tab grid. The tab grid view doesn't relayout in time for the animation to use the layout information. This CL forces a layout earlier. Additionally, the tab grid scroll position needs to be adjusted after the grid does its layout, not before. This CL moves that logic from -viewWillLayoutSubviews to -viewDidLayoutSubviews. Bug: 863107 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb15780cb9a3b52f13fbe9d875cb0695e749b96b Reviewed-on: https://chromium-review.googlesource.com/1145065 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#576834} [modify] https://crrev.com/532527e25e9c040712d0623c308de2863e300204/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/532527e25e9c040712d0623c308de2863e300204/ios/chrome/browser/ui/tab_grid/transitions/tab_to_grid_animator.mm
,
Jul 20
,
Jul 25
shbarezar@ Please verify on Canary.
,
Jul 25
Verified on canary 70.10.3502.0.
,
Jul 25
Approved.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d392717b64b67453c883bcb9b972de43cdc3934c commit d392717b64b67453c883bcb9b972de43cdc3934c Author: Mark Cogan <marq@google.com> Date: Thu Jul 26 09:16:43 2018 [iOS] Fix blank screen when entering tab grid. The tab grid view doesn't relayout in time for the animation to use the layout information. This CL forces a layout earlier. Additionally, the tab grid scroll position needs to be adjusted after the grid does its layout, not before. This CL moves that logic from -viewWillLayoutSubviews to -viewDidLayoutSubviews. Bug: 863107 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb15780cb9a3b52f13fbe9d875cb0695e749b96b Reviewed-on: https://chromium-review.googlesource.com/1145065 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576834}(cherry picked from commit 532527e25e9c040712d0623c308de2863e300204) Reviewed-on: https://chromium-review.googlesource.com/1151147 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#102} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/d392717b64b67453c883bcb9b972de43cdc3934c/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/d392717b64b67453c883bcb9b972de43cdc3934c/ios/chrome/browser/ui/tab_grid/transitions/tab_to_grid_animator.mm
,
Aug 1
Verified in 69.0.3497.22 beta iPhone 7(iOS 11.4.1), iPhone 8plus(iOS 12 beta 5) and iPhone 7plus(iOS 10.3.3) Screen doesn't goes blank on entering to tab grid from landscape |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ghendel@chromium.org
, Jul 13