New issue
Advanced search Search tips

Issue 863102 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Jul 13
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

incremental_apk_by_default builds are broken

Project Member Reported by roc...@chromium.org, Jul 12 
It seems that https://crrev.com/3ff944eef introduced some changes which break the build when |incremental_apk_by_default| is set to true. The failure is pasted below, presumably indicating that the template fails to use |additional_apks| when incremental APKs are enabled.

====

ERROR at //chrome/android/BUILD.gn:1454:23: Assignment had no effect.
    additional_apks = [ "//net/android:net_test_support_apk" ]
                      ^--------------------------------------
You set the variable "additional_apks" here and it was unused before it went
out of scope.
See //chrome/android/BUILD.gn:1444:3: whence it was called.
  instrumentation_test_apk("monochrome_public_test_ar_apk") {
  ^----------------------------------------------------------
See //BUILD.gn:328:9: which caused the file to be included.
        "//chrome/android:chrome_junit_tests",
        ^------------------------------------

Comment 1 by roc...@chromium.org, Jul 12

Summary: incremental_apk_by_default builds are broken (was: Incremental APK builds are broken)
I guess I should clarify that this doesn't really break incremental APK builds in general, just GN gen when incremental_apk_by_default=true.

I can still turn that off and successfully build e.g. chrome_public_apk_incremental.

Comment 2 by bsheedy@chromium.org, Jul 12 

I should be able to dig into this later today.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00327255fd1e880b009d34d0823684519431e650

commit 00327255fd1e880b009d34d0823684519431e650
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Jul 13 01:50:20 2018

Fix gn gen with incremental_apk_by_default

Fixes gn gen failing on Android when incremental_apk_by_default is true
due to not forwarding additional_apks for monochrome_public_test_ar_apk.

Bug:  863102 
Change-Id: If2c168e5e966f3464056131635be84ede8f568e3
Reviewed-on: https://chromium-review.googlesource.com/1135911
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574813}
[modify] https://crrev.com/00327255fd1e880b009d34d0823684519431e650/build/config/android/rules.gni

Comment 4 by bsheedy@chromium.org, Jul 13

Status: Fixed (was: Assigned)
Should be fixed now.
►

Sign in to add a comment