New issue
Advanced search Search tips

Issue 863098 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Timeout in pdf_xml_fuzzer

Project Member Reported by ClusterFuzz, Jul 12

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5143461586796544

Fuzzer: libFuzzer_pdf_xml_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_xml_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=548153:548173

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5143461586796544

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 12

Cc: dsinclair@chromium.org jam@chromium.org brucedaw...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Cc: kkaluri@chromium.org
Components: Internals>Plugins>PDF
Labels: M-68 Test-Predator-Wrong CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.

Thank You...
Cc: -jam@chromium.org -brucedaw...@chromium.org -dsinclair@chromium.org
Labels: -Pri-1 -M-68 Pri-2
Owner: dsinclair@chromium.org
Owner: rharrison@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/e819c2057ffdea90fef40d5801aec22ecd8571cd

commit e819c2057ffdea90fef40d5801aec22ecd8571cd
Author: Ryan Harrison <rharrison@chromium.org>
Date: Fri Aug 03 19:45:26 2018

Make CFX_XMLParser less permissive

Currently the parser will accept arbitrary garbage before the first
element begins. This is causing issues with ClusterFuzz since it
generates a lot of trash inputs which take a long time to parse
inspite of being invalid.

This CL adds in a check of how deep the parse is when dealing with
text, and if it is at the top level scope, then only accept the
beginning of the root node.

BUG= chromium:863098 

Change-Id: Ie45114ecf488f7e8a68a120d153033c7089d5cdc
Reviewed-on: https://pdfium-review.googlesource.com/39470
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

[modify] https://crrev.com/e819c2057ffdea90fef40d5801aec22ecd8571cd/core/fxcrt/xml/cfx_xmlparser.cpp

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d53f214bcfb39ac8adc95c851fc8d6ff9306b7e

commit 4d53f214bcfb39ac8adc95c851fc8d6ff9306b7e
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Aug 04 03:02:51 2018

Roll src/third_party/pdfium 2958a8faf500..e819c2057ffd (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/2958a8faf500..e819c2057ffd


git log 2958a8faf500..e819c2057ffd --date=short --no-merges --format='%ad %ae %s'
2018-08-03 rharrison@chromium.org Make CFX_XMLParser less permissive


Created with:
  gclient setdep -r src/third_party/pdfium@e819c2057ffd

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:863098 
TBR=dsinclair@chromium.org

Change-Id: I81774696680a4484449360a9c75cb70fad3995d4
Reviewed-on: https://chromium-review.googlesource.com/1162388
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580736}
[modify] https://crrev.com/4d53f214bcfb39ac8adc95c851fc8d6ff9306b7e/DEPS

Project Member

Comment 9 by ClusterFuzz, Aug 4

ClusterFuzz has detected this issue as fixed in range 580733:580736.

Detailed report: https://clusterfuzz.com/testcase?key=5143461586796544

Fuzzer: libFuzzer_pdf_xml_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_xml_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=548153:548173
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=580733:580736

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5143461586796544

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Aug 4

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5143461586796544 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/7f08348c98325eb303322142148440610b49fe86

commit 7f08348c98325eb303322142148440610b49fe86
Author: Ryan Harrison <rharrison@chromium.org>
Date: Mon Aug 06 17:59:16 2018

Clean up a nit that was identified after CQing an earlier CL

Change check to use empty instead of size <= 0. Also added a comment
to the check to make it clear what is being guarded against

BUG= chromium:863098 

Change-Id: I993085c04ab66a9e2869c83d8fb48883ec0bbf71
Reviewed-on: https://pdfium-review.googlesource.com/39497
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/7f08348c98325eb303322142148440610b49fe86/core/fxcrt/xml/cfx_xmlparser.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bcd41ba7ab4142b74b4d95a4417c78161774d93

commit 2bcd41ba7ab4142b74b4d95a4417c78161774d93
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 06 20:03:29 2018

Roll src/third_party/pdfium a7a957f7cec2..f3a3393a2f96 (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/a7a957f7cec2..f3a3393a2f96


git log a7a957f7cec2..f3a3393a2f96 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 thestig@chromium.org Avoid invalid object numbers in CPDF_Parser::LoadCrossRefV5().
2018-08-06 tsepez@chromium.org Small optimization in CJBig2_Image::SubImage()
2018-08-06 thestig@chromium.org Check for null object type in CPDF_Parser::LoadCrossRefV5().
2018-08-06 thestig@chromium.org Do more CPDF_Parser::LoadCrossRefV5() cleanup.
2018-08-06 rharrison@chromium.org Clean up a nit that was identified after CQing an earlier CL


Created with:
  gclient setdep -r src/third_party/pdfium@f3a3393a2f96

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:865272 , chromium:871042 , chromium:863098 
TBR=dsinclair@chromium.org

Change-Id: I244334140b9abd5f018f052799d278320c51e5fc
Reviewed-on: https://chromium-review.googlesource.com/1163845
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580959}
[modify] https://crrev.com/2bcd41ba7ab4142b74b4d95a4417c78161774d93/DEPS

Sign in to add a comment