New issue
Advanced search Search tips

Issue 863094 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Inactive window tab strip color should be different

Project Member Reported by markchang@chromium.org, Jul 12

Issue description

For the tabstrip background color, update when the window is inactive across all platforms.
 
Cc: robliao@chromium.org bettes@chromium.org ellyjo...@chromium.org
 Issue 771782  has been merged into this issue.
Labels: Group-Window_Frame
Cc: -robliao@chromium.org
Owner: robliao@chromium.org
A theme compatible version would be to blend the active tabstrip 70% against white. 
The opaque alternate to that, for default tabstrip, is #E7EAED.

https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZW9TjXpqhOa9/files/MCEhmyWmAmKVJz7eZktUlsQ2
Owner: bsep@chromium.org
Sending this over to bsep@
bettes@: What's the color for incognito?
GG800
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b17461955c48cdcf93b2424dcd620fa2ee54077

commit 0b17461955c48cdcf93b2424dcd620fa2ee54077
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Jul 17 19:07:19 2018

Change inactive window frame color per the spec.

New colors:
* Inactive normal: #E7EAED
* Inactive incognito: GoogleGrey800

Bug:  863094 
Change-Id: Ifb11031efffcf9116a8d076cc20f71c6cc4f0117
Reviewed-on: https://chromium-review.googlesource.com/1139041
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575744}
[modify] https://crrev.com/0b17461955c48cdcf93b2424dcd620fa2ee54077/chrome/browser/themes/theme_properties.cc

Status: Fixed (was: Assigned)
Labels: Needs-Feedback
Tested this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the build without fix 69.0.3486.0 and build with fix 69.0.3495.0.
Seeing the same behavior on the build without fix and build with fix. The inactive tab window color is same as in old builds.
Attached are the screen shots for reference.

bsep@ Request you to check and confirm if anything is missed from our end in verifying the issue?

Thanks..
863094-build without fix.PNG
57.6 KB View Download
863094-M69.PNG
47.0 KB View Download
Labels: -Pri-1 Pri-2
Status: Assigned (was: Fixed)
Bret, can you also update the relevant frame tints so that the effect of tinting the main/incognito frame colors gets the desired inactive colors?  This way themes that don't set their own tints will get these same effects, by the same magnitude, and it will be consistent.

(Added bonus, we could perhaps kill some of the explicit color constants and compute the default colors by tinting as well.)

Sorry to reopen your bug for this, it just seemed connected.
Labels: -Needs-Feedback
Status: Fixed (was: Assigned)
#9: Both screenshots show the expected behavior, so I'm not sure what happened there. Maybe the earlier build also has the patch?

#10: I explicitly decided not to address themes for 69. I tried to do it way back for custom titlebar and it was a big can o' worms. I would also rather it be split into its own bug.
I filed bug 865130 for that, then.

I think the can of worms you'er thinking of was the one where we were debating changing the colors at all and what to change them to -- which I think is still a can of worms, that we've decided to jump into.  Maybe I'm wrong though and there's something else I'm not aware of.

AFAIK, given a set of colors we've already chosen, changing the tints to match should be a pretty trivial fix.

Sign in to add a comment