Inactive window tab strip color should be different |
||||||||
Issue descriptionFor the tabstrip background color, update when the window is inactive across all platforms.
,
Jul 12
,
Jul 13
A theme compatible version would be to blend the active tabstrip 70% against white. The opaque alternate to that, for default tabstrip, is #E7EAED. https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZW9TjXpqhOa9/files/MCEhmyWmAmKVJz7eZktUlsQ2
,
Jul 13
Sending this over to bsep@
,
Jul 16
bettes@: What's the color for incognito?
,
Jul 16
GG800
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b17461955c48cdcf93b2424dcd620fa2ee54077 commit 0b17461955c48cdcf93b2424dcd620fa2ee54077 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jul 17 19:07:19 2018 Change inactive window frame color per the spec. New colors: * Inactive normal: #E7EAED * Inactive incognito: GoogleGrey800 Bug: 863094 Change-Id: Ifb11031efffcf9116a8d076cc20f71c6cc4f0117 Reviewed-on: https://chromium-review.googlesource.com/1139041 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#575744} [modify] https://crrev.com/0b17461955c48cdcf93b2424dcd620fa2ee54077/chrome/browser/themes/theme_properties.cc
,
Jul 17
,
Jul 18
Tested this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the build without fix 69.0.3486.0 and build with fix 69.0.3495.0. Seeing the same behavior on the build without fix and build with fix. The inactive tab window color is same as in old builds. Attached are the screen shots for reference. bsep@ Request you to check and confirm if anything is missed from our end in verifying the issue? Thanks..
,
Jul 18
Bret, can you also update the relevant frame tints so that the effect of tinting the main/incognito frame colors gets the desired inactive colors? This way themes that don't set their own tints will get these same effects, by the same magnitude, and it will be consistent. (Added bonus, we could perhaps kill some of the explicit color constants and compute the default colors by tinting as well.) Sorry to reopen your bug for this, it just seemed connected.
,
Jul 18
#9: Both screenshots show the expected behavior, so I'm not sure what happened there. Maybe the earlier build also has the patch? #10: I explicitly decided not to address themes for 69. I tried to do it way back for custom titlebar and it was a big can o' worms. I would also rather it be split into its own bug.
,
Jul 18
I filed bug 865130 for that, then. I think the can of worms you'er thinking of was the one where we were debating changing the colors at all and what to change them to -- which I think is still a can of worms, that we've decided to jump into. Maybe I'm wrong though and there's something else I'm not aware of. AFAIK, given a set of colors we've already chosen, changing the tints to match should be a pretty trivial fix. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by markchang@chromium.org
, Jul 12