Issue metadata
Sign in to add a comment
|
ChromeOS ChromeVox help text insensitive to changes in tablet mode |
||||||||||||||||||||||||
Issue description
This was seen on a pre-release Grunt convertible, but we believe it to be generic to ChromeOS. We found that the popup help instructions for disabling ChromeVox are not sensitive to subsequent changes in tablet-mode state once ChromeVox has been enabled.
Initial condition: Clamshell {Tablet Mode}
Steps to Reproduce:
- Enter ChromeVox mode via Ctrl+Alt+Z {Vol+ + Vol-}
- Swap to Tablet Mode {Clamshell} by fully rotating the screen to the tablet orientation, or vice-versa.
Expected Respone: Popup text changes to show the currently correct key combination.
Actual Response: Popup text remains in the key combination that was correct when ChromeVox was initially enabled.
,
Jul 12
,
Jul 12
,
Jul 12
,
Jul 13
What build? Can you use one of the standard bug templates?
,
Jul 13
Seen on Soraka 10820.0.0 detachable Grunt 10718.13.0 convertible Reproduction is always. User impact is confusion "How do I turn this off? The key combination isn't working!" Workaround is to use web search for ways to turn it off and hope that you find a site that gives you the alternate keyboard combination.
,
Jul 13
Again, what build of cros? 69, 67? I only ask because there's no such shortcut in tablet mode pre 68 which may be why you can't find it hence you should just go back to laptop mode and hit ctrl alt z. 68 and after, this is a valid issue. As FYI, in 68 and after, it's a 5 second hold of the volume keys to toggle ChromeVox while in tablet mode. I'm also conflicted if that's actually easier to mention and have someone try to figure out or to have the user re-issue the command that got them ChromeVox in the first place. I'll defer this question to a few others. Finally, there's also a disable ChromeVox button on-screen and eventually there'll also be a confirmation dialog to avoid accidental triggers like you may have done. + lpalmaro as FYI.
,
Jul 13
Sorry, I misunderstood the build question. The Grunt machine is 68 and the Soraka machine is on 69.
The problem is fully symmetric and was reproduced in both directions. Sorry if the {} didn't make that clear in my initial report.
If you start in tablet mode and use the volume keys to enable ChromeVox, then you do get the IDS_ASH_STATUS_TRAY_SPOKEN_FEEDBACK_ENABLED_TABLET popup text. The popup text doesn't change when you go into clamshell mode, but the sensitive key combination does change.
If you start in clamshell mode and use the Ctrl+Alt+Z to enable ChromeVox, then you do get the IDS_ASH_STATUS_TRAY_SPOKEN_FEEDBACK_ENABLED popup text. The popup text doesn't change when you go into tablet mode, but the sensitive key combination does change.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d commit 562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d Author: David Tseng <dtseng@chromium.org> Date: Wed Jul 18 03:35:05 2018 Dynamically change ChromeVox toggle help string Bug: 863093 Change-Id: I3307df10ca8c438c3683418f3e50c9e4859918bd Reviewed-on: https://chromium-review.googlesource.com/1136530 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575927} [modify] https://crrev.com/562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d/ash/accessibility/accessibility_controller.h [modify] https://crrev.com/562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d/ash/shell.cc [modify] https://crrev.com/562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d/ui/message_center/views/message_popup_collection.cc
,
Jul 18
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jbrandmeyer@chromium.org
, Jul 12