New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863085 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 751328
issue 857578
issue 840394



Sign in to add a comment

WebGL + OffscreenCanvas flickers

Project Member Reported by junov@chromium.org, Jul 12

Issue description

There is occasion flickering of WebGL when using the context via OffscreenCanvas

The flickering goes away with the preserveDrawingBuffer=true, which suggests that the code is sometimes pushing frames to the compositor when it should not.

This is probably the reason why several tests are currently marked as flaky (See The blocking field for bugs that might get fixed by fixing this issue)
 
Components: Blink>Canvas
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80f25a0bc72769f096e77e8b576ecb1cc1ff7914

commit 80f25a0bc72769f096e77e8b576ecb1cc1ff7914
Author: Justin Novosad <junov@chromium.org>
Date: Thu Jul 12 23:09:27 2018

Fix flickering in OffscreenCanvas WebGL

The fix prevents compositor frames from being pushed by
OffscreenCanvas whenever the push is unwarranted. Spurious pushes
cause flickering due to preserveDrawingBuffer=false behaviour.

BUG= 863085 

Change-Id: I24c8b4d27e6a07b41e8e0ae030d1ec626674b8d0
Reviewed-on: https://chromium-review.googlesource.com/1135520
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574768}
[modify] https://crrev.com/80f25a0bc72769f096e77e8b576ecb1cc1ff7914/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/80f25a0bc72769f096e77e8b576ecb1cc1ff7914/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h

Status: Fixed (was: Assigned)

Sign in to add a comment