Denis, can you PTAL? Maybe related to crrev.com/c/1016916?

#1 Crash in Chrome OS in 69.0.3486.0 dev responsible for ~20% of all crashes.

It seems from the Crash tool that the crashes went away with the next version 69.0.3488.0?
Has the commit r573333 from zmin@ resolved the underlying issue?

Overall, while it's unclear yet what has led to the recent spike, the original issue could be in the usage of GetActiveUserProfile() in system_log_uploader.cc file, as it may return an off-the-record sign-in-screen profile. Can we switch onto a more reliable alternative?

We still need to get logs, even if the device has no signed-in user. Most of the system_log_uploader works with files on the disk, so there is no profile dependency. 

And for policy dump that is a virtual file based on profile we should add extra safeguard checks, making policy dump a best-effort rather than relying on existence of other services at runtime.

Yes, r573333 fixes an issue which causes GetAllPolicyValuesAsDictionary crash on off-the-record profile.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/064ab3c782216e2e4f27ee267be83f5942d38622

commit 064ab3c782216e2e4f27ee267be83f5942d38622
Author: Denis Kuznetsov <antrim@google.com>
Date: Tue Jul 17 15:34:29 2018

Migrate policy_conversions from DictionaryValue to Value

Also add safeguard checks as policy dump might be requested
by log upload job at times when not all services might be
available for the profile.

Bug:  863075 
Change-Id: I45a88711c202800f89282dc0028e079bddb4324e
Reviewed-on: https://chromium-review.googlesource.com/1136533
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575649}
[modify] https://crrev.com/064ab3c782216e2e4f27ee267be83f5942d38622/chrome/browser/policy/policy_conversions.cc
[modify] https://crrev.com/064ab3c782216e2e4f27ee267be83f5942d38622/chrome/browser/policy/policy_conversions.h
[modify] https://crrev.com/064ab3c782216e2e4f27ee267be83f5942d38622/chrome/browser/ui/webui/policy_ui_handler.cc

As the CL mentioned in #6 fixed the original problem and the last CL adds extra safeguards, I believe there is no more work that should be done. Marking as fixed.

Hi Denis,
Could you please provide steps to verify this bug. Thanks.!

Repro steps:
1) Enroll a device
2) Request device logs using remote command / policy, while device is on login screen (not within user session)
3) Check that chrome does not crash while on login screen.

Using the steps in C12. I was not able to reproduce this issue on M69 Dev (10891.0.0, 69.0.3494.0).

1. Disable guest mode and public session for test OU
2. Enable auto launch of any kiosk application
3. Enroll device in domain
4. Cancel the auto launch of the kiosk application.(device should now land at sign in screen)
5. Request device logs using remote command