New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863071 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Autofill is covering the main content

Project Member Reported by asimjour@chromium.org, Jul 12

Issue description

Autofill needs to be resized to match the expected size.

This is a regression after this patch https://chromium-review.googlesource.com/c/chromium/src/+/1132325 , and it happens for all autofill popups.

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d07f06bb5c43657ce38efc57039e36287eac2a6

commit 9d07f06bb5c43657ce38efc57039e36287eac2a6
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Thu Jul 12 20:01:28 2018

VR: fix autofill popup size

Break SetAlertDialogSize into to methods. One to set the relative
size to the main content, another one to set the absolute size.
Also added comment to hosted_platform_ui to clarify the size of
the rectangle in the model.

Bug:  863071 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
Reviewed-on: https://chromium-review.googlesource.com/1132140
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574688}
[modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/vr/model/hosted_platform_ui.h
[modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/vr/ui.cc
[modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/vr/ui.h

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Labels: Merge-Request-68
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 16

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Is this merge safe?
Yes, it is safe. This only affects VR users, and brings back the scaling that was removed by mistake before.
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Please merge this as soon as possible. M68 stable cut is today.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 17

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d6b8f93f676103ee33c1b981508bc13ca6488ad

commit 9d6b8f93f676103ee33c1b981508bc13ca6488ad
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Tue Jul 17 19:50:19 2018

VR: fix autofill popup size

Break SetAlertDialogSize into to methods. One to set the relative
size to the main content, another one to set the absolute size.
Also added comment to hosted_platform_ui to clarify the size of
the rectangle in the model.

Bug:  863071 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
Reviewed-on: https://chromium-review.googlesource.com/1132140
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#574688}(cherry picked from commit 9d07f06bb5c43657ce38efc57039e36287eac2a6)
Reviewed-on: https://chromium-review.googlesource.com/1140554
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#700}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/vr/model/hosted_platform_ui.h
[modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/vr/ui.cc
[modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/vr/ui.h

Status: Fixed (was: Started)

Sign in to add a comment