Issue metadata
Sign in to add a comment
|
VR: Autofill is covering the main content |
||||||||||||||||||||||||||
Issue descriptionAutofill needs to be resized to match the expected size. This is a regression after this patch https://chromium-review.googlesource.com/c/chromium/src/+/1132325 , and it happens for all autofill popups.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d07f06bb5c43657ce38efc57039e36287eac2a6 commit 9d07f06bb5c43657ce38efc57039e36287eac2a6 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Jul 12 20:01:28 2018 VR: fix autofill popup size Break SetAlertDialogSize into to methods. One to set the relative size to the main content, another one to set the absolute size. Also added comment to hosted_platform_ui to clarify the size of the rectangle in the model. Bug: 863071 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa Reviewed-on: https://chromium-review.googlesource.com/1132140 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#574688} [modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/vr/model/hosted_platform_ui.h [modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/vr/ui.cc [modify] https://crrev.com/9d07f06bb5c43657ce38efc57039e36287eac2a6/chrome/browser/vr/ui.h
,
Jul 12
,
Jul 12
,
Jul 16
,
Jul 16
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 16
Is this merge safe?
,
Jul 16
Yes, it is safe. This only affects VR users, and brings back the scaling that was removed by mistake before.
,
Jul 17
Please merge this as soon as possible. M68 stable cut is today.
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d6b8f93f676103ee33c1b981508bc13ca6488ad commit 9d6b8f93f676103ee33c1b981508bc13ca6488ad Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Jul 17 19:50:19 2018 VR: fix autofill popup size Break SetAlertDialogSize into to methods. One to set the relative size to the main content, another one to set the absolute size. Also added comment to hosted_platform_ui to clarify the size of the rectangle in the model. Bug: 863071 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa Reviewed-on: https://chromium-review.googlesource.com/1132140 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#574688}(cherry picked from commit 9d07f06bb5c43657ce38efc57039e36287eac2a6) Reviewed-on: https://chromium-review.googlesource.com/1140554 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#700} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/vr/model/hosted_platform_ui.h [modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/vr/ui.cc [modify] https://crrev.com/9d6b8f93f676103ee33c1b981508bc13ca6488ad/chrome/browser/vr/ui.h
,
Jul 17
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by asimjour@chromium.org
, Jul 12