Create a GN target for the AR DFM APK.
Bumping to M71 as discussed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc740b07a52e8a89612b75454b17a4ad614b1e97 commit bc740b07a52e8a89612b75454b17a4ad614b1e97 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Aug 14 00:18:09 2018 [build:android] Add a module for AR in Monochrome Add an AR Dynamic Feature Module (DFM) and bundle it into the public Monochrome bundle. + Add loadable modules to the build config so that their paths can be passed to the module create target. + Add option to bundle targets to specify the Android SDK target for synchronized proguarding. This was necessary because the Monochrome base module uses a different Android SDK than the AR module, which made proguard sad. Also pass the Android SDK Jar as a dedicated classpath Jar to proguard and don't mix it with the other classpath Jars. Bug: 863063 Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e Reviewed-on: https://chromium-review.googlesource.com/1165533 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582765} [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/build/android/gyp/write_build_config.py [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/build/config/android/internal_rules.gni [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/build/config/android/rules.gni [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/chrome/android/BUILD.gn [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/chrome/android/chrome_public_apk_tmpl.gni [add] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/chrome/android/modules/ar/AndroidManifest.xml [add] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/chrome/android/modules/ar/OWNERS [add] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/chrome/android/modules/ar/README [add] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/chrome/android/modules/ar/ar_module_tmpl.gni [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/third_party/arcore-android-sdk/BUILD.gn [modify] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/third_party/arcore-android-sdk/README.chromium [add] https://crrev.com/bc740b07a52e8a89612b75454b17a4ad614b1e97/third_party/arcore-android-sdk/libarcore_dummy.so
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99c7a9db66196aac59a737e8a7a7af83adfac24b commit 99c7a9db66196aac59a737e8a7a7af83adfac24b Author: Alexandr Ilin <alexilin@chromium.org> Date: Tue Aug 14 09:24:33 2018 Revert "[build:android] Add a module for AR in Monochrome" This reverts commit bc740b07a52e8a89612b75454b17a4ad614b1e97. Reason for revert: this commit causes compile errors on several internal.client.clank builders, particularly on "monochrome_bundle" target. Failed build: https://ci.chromium.org/buildbot/internal.client.clank/arm-builder-rel/20238 Original change's description: > [build:android] Add a module for AR in Monochrome > > Add an AR Dynamic Feature Module (DFM) and bundle it into the public > Monochrome bundle. > > + Add loadable modules to the build config so that their paths can be > passed to the module create target. > > + Add option to bundle targets to specify the Android SDK target for > synchronized proguarding. This was necessary because the Monochrome > base module uses a different Android SDK than the AR module, which > made proguard sad. Also pass the Android SDK Jar as a dedicated > classpath Jar to proguard and don't mix it with the other classpath > Jars. > > Bug: 863063 > Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e > Reviewed-on: https://chromium-review.googlesource.com/1165533 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582765} TBR=vollick@chromium.org,yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I87ab63c3153018390f4018527d760bbd10cdcd16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863063 Reviewed-on: https://chromium-review.googlesource.com/1174271 Reviewed-by: Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582871} [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/build/android/gyp/write_build_config.py [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/build/config/android/internal_rules.gni [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/build/config/android/rules.gni [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/chrome/android/BUILD.gn [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/chrome/android/chrome_public_apk_tmpl.gni [delete] https://crrev.com/b0198b937f700cc219121ae1e0afc2eb187d0810/chrome/android/modules/ar/AndroidManifest.xml [delete] https://crrev.com/b0198b937f700cc219121ae1e0afc2eb187d0810/chrome/android/modules/ar/OWNERS [delete] https://crrev.com/b0198b937f700cc219121ae1e0afc2eb187d0810/chrome/android/modules/ar/README [delete] https://crrev.com/b0198b937f700cc219121ae1e0afc2eb187d0810/chrome/android/modules/ar/ar_module_tmpl.gni [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/third_party/arcore-android-sdk/BUILD.gn [modify] https://crrev.com/99c7a9db66196aac59a737e8a7a7af83adfac24b/third_party/arcore-android-sdk/README.chromium [delete] https://crrev.com/b0198b937f700cc219121ae1e0afc2eb187d0810/third_party/arcore-android-sdk/libarcore_dummy.so
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4094cdde14c9b6d0bf98609f0b4db40b18485121 commit 4094cdde14c9b6d0bf98609f0b4db40b18485121 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Aug 16 16:20:04 2018 Reland "[build:android] Add a module for AR in Monochrome" This is a reland of bc740b07a52e8a89612b75454b17a4ad614b1e97 with a fix to include the loadable modules into the final APK. Original change's description: > [build:android] Add a module for AR in Monochrome > > Add an AR Dynamic Feature Module (DFM) and bundle it into the public > Monochrome bundle. > > + Add loadable modules to the build config so that their paths can be > passed to the module create target. > > + Add option to bundle targets to specify the Android SDK target for > synchronized proguarding. This was necessary because the Monochrome > base module uses a different Android SDK than the AR module, which > made proguard sad. Also pass the Android SDK Jar as a dedicated > classpath Jar to proguard and don't mix it with the other classpath > Jars. > > Bug: 863063 > Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e > Reviewed-on: https://chromium-review.googlesource.com/1165533 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582765} TBR=tedchoc@chromium.org Bug: 863063 , 873986 Change-Id: I4a72667027ab283b43685197c980b46e90553df8 Reviewed-on: https://chromium-review.googlesource.com/1174772 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#583682} [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/build/android/gyp/write_build_config.py [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/build/config/android/internal_rules.gni [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/build/config/android/rules.gni [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/chrome/android/BUILD.gn [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/chrome/android/chrome_public_apk_tmpl.gni [add] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/chrome/android/modules/ar/AndroidManifest.xml [add] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/chrome/android/modules/ar/OWNERS [add] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/chrome/android/modules/ar/README [add] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/chrome/android/modules/ar/ar_module_tmpl.gni [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/third_party/arcore-android-sdk/BUILD.gn [modify] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/third_party/arcore-android-sdk/README.chromium [add] https://crrev.com/4094cdde14c9b6d0bf98609f0b4db40b18485121/third_party/arcore-android-sdk/libarcore_dummy.so
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b0fc0fb1aeefce61bfa88e7058f26161d11d974 commit 5b0fc0fb1aeefce61bfa88e7058f26161d11d974 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Aug 17 15:34:05 2018 [ar] Pass bundle module name via variable and set it to "ArPublicModule" This is required so that the public and internal AR module can have different names. Bug: 863063 Change-Id: If0151c862efa2074f00868519c7f68d39836c538 Reviewed-on: https://chromium-review.googlesource.com/1178882 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584079} [modify] https://crrev.com/5b0fc0fb1aeefce61bfa88e7058f26161d11d974/chrome/android/BUILD.gn [modify] https://crrev.com/5b0fc0fb1aeefce61bfa88e7058f26161d11d974/chrome/android/modules/ar/AndroidManifest.xml [modify] https://crrev.com/5b0fc0fb1aeefce61bfa88e7058f26161d11d974/chrome/android/modules/ar/ar_module_tmpl.gni
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/10cabca9f1382401ef841c39970989ff9d1e51f7 commit 10cabca9f1382401ef841c39970989ff9d1e51f7 Author: Tibor Goldschwendt <tiborg@google.com> Date: Mon Aug 20 16:01:50 2018
Comment 1 by tiborg@chromium.org
, Jul 12