New issue
Advanced search Search tips

Issue 863043 link

Starred by 2 users
Status: Verified
Owner:
rohitrao@chromium.org
Closed: Jul 16
Cc:
martijnb@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

UX nits for settings

Project Member Reported by rohitrao@chromium.org, Jul 12 
- The seperators are too short, in case there is no cell icon. 
- Passwords: For the second line, use the "Cell Sublabel leading edge  #8E8E93 - 12pt" styling
- Autofill Forms > Edit Address: Roboto still shows up here. 
- Content Settings > Google Translate: "Reset Translate Settings" in Roboto
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16100786854d996355cd2b31b0f8fe382de98549

commit 16100786854d996355cd2b31b0f8fe382de98549
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jul 16 18:34:24 2018

[ios] Makes small tweaks to the UIRefresh settings UI.

These tweaks are based on feedback from UX.  See the linked bug
for details.

BUG= 863043 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I159c77e16c567b5b670ca727425253fc8a393ebe
Reviewed-on: https://chromium-review.googlesource.com/1135289
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575358}
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/cells/settings_text_item.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
[modify] https://crrev.com/16100786854d996355cd2b31b0f8fe382de98549/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

Comment 2 by rohitrao@chromium.org, Jul 16

Status: Fixed (was: Started)
►

Sign in to add a comment