Composite SVG filter parameters affect previous drawImage call
Reported by
ivan.pop...@gmail.com,
Jul 12
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 Steps to reproduce the problem: Open https://jsfiddle.net/yeh1u5cv/3/ or attached file What is the expected behavior? Left square has red shadow, right square has green shadow. What went wrong? Both have red shadow. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 66.0.3359.181 Channel: stable OS Version: 10.0 Flash Version: if you uncomment RaF, you'll see how that both shadows are green. if you uncomment try-catch , you'll see that canvas is tainted, i dont know if its the same bug or another. It doesnt happen with simple ColorMatrix. It works in firefox.
,
Jul 12
Tainting is probably part of the same bug. I have a suspicion this is deliberate to prevent leakage of user information.
,
Jul 12
I think the tainting is expected here per the limitations of the current implementation. Given that seems to be specific to the feFlood@flood-color in the example (mutating the stdDeviation in the push() function reflects fine), and said attribute is a presentation attribute, it'd seem likely that the <canvas> code is not ensuring style is clean before resolving the filter.
,
Jul 12
(Throwing in a statement that forces layout seems to fix rendering, increasing the likelihood of that being the issue.)
,
Jul 13
> I think the tainting is expected here per the limitations of the current implementation. Its fine. Just tell me whether to create new long-living issue for it after feFlood@flood-color gets resolved.
,
Jul 13
No need for that, we have one already: issue 792518. But thanks for the offer.
,
Aug 22
,
Aug 22
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e07b5b9aa717bb23d9dcc0a9f5d1760afab3331 commit 9e07b5b9aa717bb23d9dcc0a9f5d1760afab3331 Author: Aaron Krajeski <aaronhk@google.com> Date: Fri Aug 24 20:32:59 2018 Update style when url filter changes Bug: 863037 Change-Id: I2d0b34d0a6e3b7199e6dd8ec183d13f7aec2e7c4 Reviewed-on: https://chromium-review.googlesource.com/1187391 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#585972} [add] https://crrev.com/9e07b5b9aa717bb23d9dcc0a9f5d1760afab3331/third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-svg-attribute-change-expected.html [add] https://crrev.com/9e07b5b9aa717bb23d9dcc0a9f5d1760afab3331/third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-svg-attribute-change.html [modify] https://crrev.com/9e07b5b9aa717bb23d9dcc0a9f5d1760afab3331/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_state.cc
,
Aug 31
|
||||
►
Sign in to add a comment |
||||
Comment 1 by caryclark@google.com
, Jul 12