New issue
Advanced search Search tips

Issue 863029 link

Starred by 1 user
Status: Fixed
Owner:
eirage@chromium.org
Closed: Jul 12
Cc:
nzolghadr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Pen pointerevents clientX/Y are sometimes incorrect

Project Member Reported by nzolghadr@chromium.org, Jul 12 
Looking at
http://w3c.github.io/test-results/pointerevents/all.html

it seems that client X/Y for pen events are sometime incorrect (like "Inner frame pen pointerenter's ClientX and ClientY attributes are correct"). I wonder if this is due to the floating point coordinates or something is wrong with the test itself.

Ella, could you also give it a try and see what could be causing this?

Comment 1 by eirage@chromium.org, Jul 12 

The failing test is asserting left <= clientX < right && top <= clientY < bottom.
I was able to see some pointerover events have clientY == bottom with some zooming setting (e.g dsf = 1.5, pagezoom = 1.25). 
Not sure why this is not happened without zooming.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df94a28e9988135e91dc8d0d841864344b7cde7c

commit df94a28e9988135e91dc8d0d841864344b7cde7c
Author: Ella Ge <eirage@chromium.org>
Date: Thu Jul 12 17:39:20 2018

update hoverable pointerevent wpt

Update test wpt/pointerevent_attributes_hoverable_pointers

This test was failing occationally on manual test, when we have
clientX == box.right or clientY == box.bottom.
update the test assertion so coordinates on border can be consider
inside box.

Note that on right border can also be outside box for the mouseevents.
because we truncate the coordinates into interger.

Bug:  863029 
Change-Id: Id20fbe0b6cf8566e6cdee229f427a0c747ed0c0a
Reviewed-on: https://chromium-review.googlesource.com/1135432
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574624}
[modify] https://crrev.com/df94a28e9988135e91dc8d0d841864344b7cde7c/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html

Comment 3 by eirage@chromium.org, Jul 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment