and move the methods to the parent. Github issue here: https://github.com/WICG/background-fetch/pull/85
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a87f0b8406423b6a017e888a91cd0b342ee0387 commit 9a87f0b8406423b6a017e888a91cd0b342ee0387 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Jul 23 21:30:40 2018 [Background Fetch] Get settled fetches for a specific request. Two capabilities have been added to the GetSettledFetches task: 1. Support CacheQueryOptions, while fetching responses for completed fetches from the Cache Storage. 2. Support for filtering responses corresponding to a specific request from completed fetches. Both will be useful to support match() and matchAll() methods on BackgroundFetchSettledEvent. Bug: 863016 Change-Id: Icababdd71cd1687644cacc9460550de89bdfc4d5 Reviewed-on: https://chromium-review.googlesource.com/1140324 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#577269} [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/BUILD.gn [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/background_fetch_data_manager.h [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [add] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/background_fetch_request_match_params.cc [add] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/background_fetch_request_match_params.h [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/9a87f0b8406423b6a017e888a91cd0b342ee0387/content/browser/background_fetch/storage/get_settled_fetches_task.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f commit 90d1f5a1165e610dbed9b5207ffb2c488f37aa4f Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Aug 21 18:13:12 2018 [Background Fetch] Implement match and matchAll() Implement these on BackgroundFetchRegistration, which is, in turn, exposed on all Background Fetch events surfaced to the developers. Bug: 863016 Change-Id: If6406b800b595df285d7304652948063c80ac45b Reviewed-on: https://chromium-review.googlesource.com/1177394 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584826} [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_request_match_params.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_request_match_params.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_service_impl.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/background_fetch_service_impl.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/browser/background_fetch/storage/get_settled_fetches_task.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/common/background_fetch/background_fetch_types.typemap [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/content/common/service_worker/service_worker.mojom [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/90d1f5a1165e610dbed9b5207ffb2c488f37aa4f/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b9f6363f6383422923789ad72bce584e3f27470 commit 2b9f6363f6383422923789ad72bce584e3f27470 Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 15:27:01 2018 [BackgroundFetch] Part 1: Remove BackgroundFetchSettledFetches. This removes BackgroundFetchSettledFetches from blink, idl files, and the WPT tests. In a follow up CL I'll remove it from all the event dispatcher code on the browser side. This fix also makes cache_query_params optional in MatchRequests() in mojo. This is required because otherwise the mojo bindings logic crashes the renderer when we try to pass in a nullptr for cache_query_params from blink. Bug: 869918 , 863016 Change-Id: Ifa933451f98f82902d8455ba5401c629c8c24811 Reviewed-on: https://chromium-review.googlesource.com/1186735 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585847} [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/BUILD.gn [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/BUILD.gn [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.cc [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.h [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.idl [delete] https://crrev.com/fcc71691d1795a8688b552b77dc6032293fdc39c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches_test.cc [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.h [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.idl [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/modules_idl_files.gni [modify] https://crrev.com/2b9f6363f6383422923789ad72bce584e3f27470/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d486be14ccd9bfa6f39e29b95bd417514f4f493 commit 7d486be14ccd9bfa6f39e29b95bd417514f4f493 Author: Mugdha Lakhani <nator@chromium.org> Date: Wed Aug 29 12:52:42 2018 [BackgroundFetch]: Part2: Remove BackgroundFetchSettledFetches. This removes the class from browser code, stops sending it across with various BackgroundFetch events, and also gets rid of WebBackgroundFetchSettledFetch in blink. Some converter fuctions can also be deleted. I've updated two unittests in background_fetch_service_unittest.cc to call MatchRequests() and check that all properties have been set on the settled fetches as expected. Bug: 869918 , 863016 Change-Id: I7e9729c3c120e70f2dfc70a493a900420e46e848 Reviewed-on: https://chromium-review.googlesource.com/1187101 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#587086} [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_event_dispatcher.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/common/service_worker/service_worker.mojom [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/public/BUILD.gn [delete] https://crrev.com/374d0f6b15610eada09f473761de4615fdb64652/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_settled_fetch.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc [modify] https://crrev.com/7d486be14ccd9bfa6f39e29b95bd417514f4f493/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
Comment 1 by bugdroid1@chromium.org
, Jul 23