Able to reproduce the issue on 60.0.3072.0(M-60),reported version 66.0.3359.181 and latest 69.0.3489.0 on Windows 10, Ubuntu 17.10 and Mac 10.12.6. This is a non-regression issue as it is observed from M60 old builds.

Attached screen cast for reference.

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!

Deleted: 863008.mp4 3.9 MB

	863008.mp4 3.9 MB View Download

Trying to clarify the intended behavior.


Is this what we want:

* if the user sets a custom avatar A, then turns Sync on and off, the avatar A should be restored.

* if the user sets a custom avatar A, then turns Sync on, sets another custom avatar B, turns sync off, then the avatar A should not be restored (avatar B should stay)

Actually I'm not quite sure what we should do about the second bullet (with avatar A and B), but maybe it's such an edge case that it's not really important now.

--Chrome Identity automated triaging--

This bug is Untriaged and has gone for two weeks without any activity, so it is being moved to Available. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Assigning to Sabine to define intended product behavior. Personally, I think that if you sync to an account that has a custom avatar set, that custom avatar should be set for the syncing profile as well. I don't think we necessarily *have* to change it back to an "old" custom avatar after the user stops syncing in that profile.

Either way, this is low priority. I'll let Sabine say what the intended behavior should be.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec686dc0ec5b8706a01dad1663f80f771da8a269

commit ec686dc0ec5b8706a01dad1663f80f771da8a269
Author: Pavel Beloborodov <boocmp@yandex-team.ru>
Date: Mon Aug 13 10:21:25 2018

Restore avatar after user logs out from sync.

BUG=863008

Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9

R=bauerb@chromium.org,sky@chromium.org

Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9
Reviewed-on: https://chromium-review.googlesource.com/1135137
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582541}
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/browser/profiles/gaia_info_update_service.cc
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/browser/profiles/gaia_info_update_service_unittest.cc
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/common/pref_names.cc
[modify] https://crrev.com/ec686dc0ec5b8706a01dad1663f80f771da8a269/chrome/common/pref_names.h

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b49dd022282696d499bd6cdf2ebee7a2547f5cd

commit 8b49dd022282696d499bd6cdf2ebee7a2547f5cd
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Mon Nov 12 09:34:52 2018

Revert "Restore avatar after user logs out from sync."

This reverts commit ec686dc0ec5b8706a01dad1663f80f771da8a269.

Reason for revert:
The fix does not work in all cases and it adds a lot of complexity in
the way avatar images are now used. There are now 3 sources of truth for
the avatar icon index and it is not clear what the relationship between
them is:
* kAccountIdKey in the profile entry cache
* kProfileAvatarIndex which is a synced pref.
* kLocalProfileAvatarIndex which is non-syncable pref.

Note that kProfileAvatarIndex and kLocalProfileAvatarIndex are both set
when the user updates the image icon in chrome://settings/manageProfile.

I've just tested and if I start sync, set a local avatar icon, then turn
off sync, I still have the same image. So this CL does not fix the bug
863008 for this scenario.

The core issue comes from the fact that we try to fix a problem that
cannot be fixed in the current architecture of sync - sync preferences
do not have a local variant and do not get reverted to a local variant when
the user turns sync off. I think doing a custom implementation for the profile
avatar (and not for the profile name for example or settings) just adds confusion.

The fact that the relationship between these preferences is not very clear,
fixing the  issue 900374  becomes hard and is risky.

Bug:  900374 

Original change's description:
> Restore avatar after user logs out from sync.
>
> BUG=863008
>
> Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9
>
> R=​bauerb@chromium.org,sky@chromium.org
>
> Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9
> Reviewed-on: https://chromium-review.googlesource.com/1135137
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582541}

TBR=sky@chromium.org,droger@chromium.org,bauerb@chromium.org,tangltom@chromium.org,boocmp@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863008
Change-Id: I46aed023494d94e197828339f6870bf9ba0c9da8
Reviewed-on: https://chromium-review.googlesource.com/c/1329153
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607176}
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/browser/profiles/gaia_info_update_service.cc
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/browser/profiles/gaia_info_update_service_unittest.cc
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/common/pref_names.cc
[modify] https://crrev.com/8b49dd022282696d499bd6cdf2ebee7a2547f5cd/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11

commit 750491e4e361bcc8bb66b2285a5e90a2a1ce6c11
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Thu Nov 15 16:31:39 2018

Revert "Restore avatar after user logs out from sync."

This reverts commit ec686dc0ec5b8706a01dad1663f80f771da8a269.

Reason for revert:
The fix does not work in all cases and it adds a lot of complexity in
the way avatar images are now used. There are now 3 sources of truth for
the avatar icon index and it is not clear what the relationship between
them is:
* kAccountIdKey in the profile entry cache
* kProfileAvatarIndex which is a synced pref.
* kLocalProfileAvatarIndex which is non-syncable pref.

Note that kProfileAvatarIndex and kLocalProfileAvatarIndex are both set
when the user updates the image icon in chrome://settings/manageProfile.

I've just tested and if I start sync, set a local avatar icon, then turn
off sync, I still have the same image. So this CL does not fix the bug
863008 for this scenario.

The core issue comes from the fact that we try to fix a problem that
cannot be fixed in the current architecture of sync - sync preferences
do not have a local variant and do not get reverted to a local variant when
the user turns sync off. I think doing a custom implementation for the profile
avatar (and not for the profile name for example or settings) just adds confusion.

The fact that the relationship between these preferences is not very clear,
fixing the  issue 900374  becomes hard and is risky.

Bug:  900374 

Original change's description:
> Restore avatar after user logs out from sync.
>
> BUG=863008
>
> Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9
>
> R=​bauerb@chromium.org,sky@chromium.org
>
> Change-Id: If083bc0703e251fb6e9c597fe5b7f842e37875c9
> Reviewed-on: https://chromium-review.googlesource.com/1135137
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582541}

TBR=sky@chromium.org,droger@chromium.org,bauerb@chromium.org,tangltom@chromium.org,boocmp@yandex-team.ru

(cherry picked from commit 8b49dd022282696d499bd6cdf2ebee7a2547f5cd)

Bug: 863008
Change-Id: I46aed023494d94e197828339f6870bf9ba0c9da8
Reviewed-on: https://chromium-review.googlesource.com/c/1329153
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607176}
Reviewed-on: https://chromium-review.googlesource.com/c/1338102
Cr-Commit-Position: refs/branch-heads/3578@{#691}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/browser/profiles/gaia_info_update_service.cc
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/browser/profiles/gaia_info_update_service_unittest.cc
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/common/pref_names.cc
[modify] https://crrev.com/750491e4e361bcc8bb66b2285a5e90a2a1ce6c11/chrome/common/pref_names.h