A blank grey color screen is displayed when New tab “+” button and “Close All” button are simultaneously tapped. |
|||||||||||
Issue descriptionApp Version: 69.0.3489.0 canary iOS Version: 11.4.1 (not reproducible on iOS 12 devices) Device: iPad, iPhones URL: Steps to reproduce: 1. Open chrome canary. 2. Tap tab switcher button 3. Tap simultaneously on “+” and “Close All”. 4. Tap in omnibox --> Enter any URL --> Tap on “Go” on keyboard Observed results: At Step 3: Notice that a blank grey color screen is displayed. At Step 4: App crashes Crash Log: https://crash.corp.google.com/browse?stbtiq=fae9c3037f85377b Expected results: App should not allow 2 actions at a time or immediately one after the other. Number of times you were able to reproduce: 2/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA on M67 Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M68 Link to video/image: https://drive.google.com/file/d/1qGsgQnj_Mi1h9EkFmezRYs8v4LixM7KJ/view?usp=sharing Stack Trace: Thread 0 (id: 0x303) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x00000010 ] MAGIC SIGNATURE THREAD Stack Quality 84%Show frame trust levels 0x0000000100d8c7e4 (Chrome -__tree:1064 ) base::SupportsUserData::GetUserData(void const*) const 0x0000000100af5210 (Chrome -web_state_user_data.h:46 ) -[BrowserViewController loadURLWithParams:] 0x0000000100790944 (Chrome -location_bar_coordinator.mm:206 ) -[LocationBarCoordinator loadGURLFromLocationBar:transition:] 0x000000010071b590 (Chrome -web_omnibox_edit_controller_impl.mm:46 ) WebOmniboxEditControllerImpl::OnAutocompleteAccept(GURL const&, WindowOpenDisposition, ui::PageTransition, AutocompleteMatchType::Type) 0x00000001017a429c (Chrome -omnibox_edit_model.cc:720 ) OmniboxEditModel::OpenMatch(AutocompleteMatch, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) 0x00000001017aa68c (Chrome -omnibox_view.cc:95 ) OmniboxView::OpenMatch(AutocompleteMatch const&, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) 0x0000000100722c18 (Chrome -omnibox_popup_view_ios.mm:119 ) OmniboxPopupViewIOS::OnMatchSelected(AutocompleteMatch const&, unsigned long) 0x000000010071e010 (Chrome -omnibox_popup_mediator.mm:114 ) -[OmniboxPopupMediator autocompleteResultConsumer:didSelectRow:] 0x0000000100722330 (Chrome -omnibox_popup_view_controller.mm:594 ) -[OmniboxPopupViewController tableView:didSelectRowAtIndexPath:] 0x000000018b28bed8 (UIKit + 0x0034fed8 ) -[UITableView _selectRowAtIndexPath:animated:scrollPosition:notifyDelegate:] 0x000000018b2dfb5c (UIKit + 0x003a3b5c ) -[UITableView _userSelectRowAtPendingSelectionIndexPath:] 0x000000018b36a880 (UIKit + 0x0042e880 ) _runAfterCACommitDeferredBlocks 0x000000018b360954 (UIKit + 0x00424954 ) _cleanUpAfterCAFlushAndRunDeferredBlocks 0x000000018b245518 (UIKit + 0x00309518 ) _afterCACommitHandler 0x000000018131e90c (CoreFoundation + 0x000ed90c ) __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 0x000000018131c234 (CoreFoundation + 0x000eb234 ) __CFRunLoopDoObservers 0x000000018131c880 (CoreFoundation + 0x000eb880 ) __CFRunLoopRun 0x000000018123cda4 (CoreFoundation + 0x0000bda4 ) CFRunLoopRunSpecific 0x000000018322101c (GraphicsServices + 0x0000b01c ) GSEventRunModal 0x000000018b259754 (UIKit + 0x0031d754 ) UIApplicationMain 0x0000000100370490 (Chrome -chrome_exe_main.mm:54 ) main 0x0000000180ccdfbc (libdyld.dylib + 0x00000fbc ) start
,
Jul 16
P1 since it's a crasher. Strategy for handling this may be to lock out the other toolbar buttons once the handling for one of them begins.
,
Jul 16
,
Jul 25
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/923b8f5ea9b06dd6306c1ce61ec6d13eaa4de8ae commit 923b8f5ea9b06dd6306c1ce61ec6d13eaa4de8ae Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Jul 26 03:55:51 2018 [ios] Make Tabgrid Bottom Toolbar buttons exclusive touch This prevents multiple button action methods from being triggered at the same time. Bug: 863007 Change-Id: Ic39f6270fc604eff6aa0fed3c7103123e539b193 Reviewed-on: https://chromium-review.googlesource.com/1150634 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#578187} [modify] https://crrev.com/923b8f5ea9b06dd6306c1ce61ec6d13eaa4de8ae/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jul 26
,
Jul 26
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 26
,
Jul 27
,
Jul 27
verified on canary as of 7/27
,
Jul 28
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
Manually approved as well!
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b74be5986aa8434f27344d2f9fe3d95515ae87a commit 2b74be5986aa8434f27344d2f9fe3d95515ae87a Author: sczs <sczs@chromium.org> Date: Mon Jul 30 18:32:22 2018 [ios] Make Tabgrid Bottom Toolbar buttons exclusive touch This prevents multiple button action methods from being triggered at the same time. Bug: 863007 TBR=thegreenfrog@chromium.org (cherry picked from commit 923b8f5ea9b06dd6306c1ce61ec6d13eaa4de8ae) Change-Id: Ic39f6270fc604eff6aa0fed3c7103123e539b193 Reviewed-on: https://chromium-review.googlesource.com/1150634 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578187} Reviewed-on: https://chromium-review.googlesource.com/1155383 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#223} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2b74be5986aa8434f27344d2f9fe3d95515ae87a/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jul 31
Verified on chrome canary version 70.0.3508.0 on iPhone 8 plus and iPad pro with iOS 11.4.1, following the steps mentioned in comment #0. No crashes observed. Looks good. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kkhorimoto@chromium.org
, Jul 12Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)