[iOS] Reading List Bug: Tapping on “Mark All Unread” or “Mark All Read” does not remove reading list articles from edit state. |
||||
Issue descriptionApp Version: 69.0.3489.0 canary iOS Version: 11.4.1 Device: iPhones, iPads URL: Precondition: 1. Go to: chrome://flags -> Enable #collections-ui-reboot 2. Have all reading list items in either read or unread state. Steps to reproduce: 1. Launch chrome canary 2. Add an article to Reading List 3. Go to Menu --> Reading List --> Edit 4. Do not select any of the reading list items 5. Tap on Mark All… --> Mark All Unread ( or Mark All read) Observed results: Reading list items are still in Edit state Expected results: Reading list items should be removed from Edit state Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA on M67 Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M68 Link to video/image: https://drive.google.com/file/d/1hIrfVV4UUMrKf8VKuLA8Tq6TS14WJZi2/view?usp=sharing
,
Jul 13
,
Jul 13
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/828bbe3d0aa274b5e8418e73a27e13e07b19b03c commit 828bbe3d0aa274b5e8418e73a27e13e07b19b03c Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Jul 13 18:49:00 2018 [iOS] End editing if attempty to update non-existant section. When attempting to update the read status of a section, exit editing mode before early returning if that section does not exist. Bug: 863006 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I32a0d80a3d16d7bdb0606cedbaf20401df67a640 Reviewed-on: https://chromium-review.googlesource.com/1136022 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574997} [modify] https://crrev.com/828bbe3d0aa274b5e8418e73a27e13e07b19b03c/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Jul 13
,
Jul 17
Issue verified Version: Chrome Canary 69.0.3494.0 Device: iPhone 8 iOS: 11.4 Mark all read/unread works as expected https://drive.google.com/open?id=1XuNUGd_xO7aFjDTVz573ZyFwsr8I75dC |
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Jul 12